Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2129793002: Add closure_compilation to `git cl try` for CLs that touch resources (Closed)

Created:
4 years, 5 months ago by Dan Beam
Modified:
4 years, 5 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add closure_compilation to `git cl try` for CLs that touch resources R=dpapad@chromium.org BUG=none CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation NOTRY=true Committed: https://crrev.com/2d0143560f25e9589140c4d9198a0e5e45d02c33 Cr-Commit-Position: refs/heads/master@{#403978}

Patch Set 1 : slaves -> masters #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M chrome/browser/resources/PRESUBMIT.py View 1 chunk +8 lines, -0 lines 0 comments Download
M ui/webui/resources/PRESUBMIT.py View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Dan Beam
4 years, 5 months ago (2016-07-06 22:58:16 UTC) #4
dpapad
lgtm
4 years, 5 months ago (2016-07-06 23:14:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2129793002/20001
4 years, 5 months ago (2016-07-06 23:25:46 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 5 months ago (2016-07-06 23:36:45 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-06 23:36:59 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2d0143560f25e9589140c4d9198a0e5e45d02c33 Cr-Commit-Position: refs/heads/master@{#403978}
4 years, 5 months ago (2016-07-06 23:39:27 UTC) #13
Dan Beam
4 years, 5 months ago (2016-07-11 23:49:31 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:20001) has been created in
https://codereview.chromium.org/2142553004/ by dbeam@chromium.org.

The reason for reverting is: Just use CQ dry run instead.

See also, recent improvements:
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/Ale4kvbwVS8/dis....

Powered by Google App Engine
This is Rietveld 408576698