Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Side by Side Diff: chrome/browser/resources/PRESUBMIT.py

Issue 2129793002: Add closure_compilation to `git cl try` for CLs that touch resources (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: slaves -> masters Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ui/webui/resources/PRESUBMIT.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Presubmit script for files in chrome/browser/resources. 5 """Presubmit script for files in chrome/browser/resources.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into depot_tools. 8 for more details about the presubmit API built into depot_tools.
9 """ 9 """
10 10
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 new_description = re.sub(tag_reg, new_tag, description, flags=re.M | re.I) 113 new_description = re.sub(tag_reg, new_tag, description, flags=re.M | re.I)
114 else: 114 else:
115 new_description = description + '\n' + new_tag 115 new_description = description + '\n' + new_tag
116 116
117 if new_description == description: 117 if new_description == description:
118 return [] 118 return []
119 119
120 rietveld_obj.update_description(cl.issue, new_description) 120 rietveld_obj.update_description(cl.issue, new_description)
121 return [output_api.PresubmitNotifyResult( 121 return [output_api.PresubmitNotifyResult(
122 'Automatically added optional Closure bots to run on CQ.')] 122 'Automatically added optional Closure bots to run on CQ.')]
123
124
125 def GetPreferredTryMasters(project, change):
126 return {
127 'tryserver.chromium.linux': {
128 'closure_compilation': set(['defaulttests']),
129 },
130 }
OLDNEW
« no previous file with comments | « no previous file | ui/webui/resources/PRESUBMIT.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698