Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py

Issue 2129733002: Add get_issue_number function to webkitpy/common/checkout/scm/git.py (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: adds another testcase for test_get_issue_number in scm_unittest Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py
index 9f662cd972aec28f038a8deff8c16dac7754ba27..776320286c5679e76055fe273ac499a70c0ab782 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py
@@ -31,7 +31,7 @@
import unittest
from webkitpy.common.system.executive import Executive, ScriptError
-from webkitpy.common.system.executive_mock import MockExecutive
+from webkitpy.common.system.executive_mock import MockExecutive, MockExecutive2
from webkitpy.common.system.filesystem import FileSystem
from webkitpy.common.system.filesystem_mock import MockFileSystem
from webkitpy.common.checkout.scm.detection import detect_scm_system
@@ -254,3 +254,11 @@ class GitTestWithMock(SCMTestBase):
scm._run_git = lambda args: 'Date: 2013-02-08 01:55:21 -0800'
self.assertEqual(scm.timestamp_of_revision('some-path', '12345'), '2013-02-08T09:55:21Z')
+
+ def test_get_issue_number(self):
+ scm = Git(cwd='.', executive=MockExecutive2(output='Issue number: 12345 (http://crrev.com/12345)'))
+ issue_number = scm.get_issue_number()
+ self.assertEqual(issue_number, '12345')
+ scm2 = Git(cwd='.', executive=MockExecutive2(output='Issue number: None (None)'))
+ issue_number = scm2.get_issue_number()
+ self.assertEqual(issue_number, 'None')
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698