Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py

Issue 2129733002: Add get_issue_number function to webkitpy/common/checkout/scm/git.py (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: adds another testcase for test_get_issue_number in scm_unittest Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (C) 2009 Google Inc. All rights reserved. 1 # Copyright (C) 2009 Google Inc. All rights reserved.
2 # Copyright (C) 2009 Apple Inc. All rights reserved. 2 # Copyright (C) 2009 Apple Inc. All rights reserved.
3 # Copyright (C) 2011 Daniel Bates (dbates@intudata.com). All rights reserved. 3 # Copyright (C) 2011 Daniel Bates (dbates@intudata.com). All rights reserved.
4 # 4 #
5 # Redistribution and use in source and binary forms, with or without 5 # Redistribution and use in source and binary forms, with or without
6 # modification, are permitted provided that the following conditions are 6 # modification, are permitted provided that the following conditions are
7 # met: 7 # met:
8 # 8 #
9 # * Redistributions of source code must retain the above copyright 9 # * Redistributions of source code must retain the above copyright
10 # notice, this list of conditions and the following disclaimer. 10 # notice, this list of conditions and the following disclaimer.
(...skipping 13 matching lines...) Expand all
24 # SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 24 # SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
25 # LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 25 # LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
26 # DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 26 # DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
27 # THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 27 # THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
28 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 28 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
29 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 29 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
30 30
31 import unittest 31 import unittest
32 32
33 from webkitpy.common.system.executive import Executive, ScriptError 33 from webkitpy.common.system.executive import Executive, ScriptError
34 from webkitpy.common.system.executive_mock import MockExecutive 34 from webkitpy.common.system.executive_mock import MockExecutive, MockExecutive2
35 from webkitpy.common.system.filesystem import FileSystem 35 from webkitpy.common.system.filesystem import FileSystem
36 from webkitpy.common.system.filesystem_mock import MockFileSystem 36 from webkitpy.common.system.filesystem_mock import MockFileSystem
37 from webkitpy.common.checkout.scm.detection import detect_scm_system 37 from webkitpy.common.checkout.scm.detection import detect_scm_system
38 from webkitpy.common.checkout.scm.git import AmbiguousCommitError 38 from webkitpy.common.checkout.scm.git import AmbiguousCommitError
39 from webkitpy.common.checkout.scm.git import Git 39 from webkitpy.common.checkout.scm.git import Git
40 from webkitpy.common.checkout.scm.scm import SCM 40 from webkitpy.common.checkout.scm.scm import SCM
41 41
42 42
43 class SCMTestBase(unittest.TestCase): 43 class SCMTestBase(unittest.TestCase):
44 44
(...skipping 202 matching lines...) Expand 10 before | Expand all | Expand 10 after
247 scm = self.make_scm() 247 scm = self.make_scm()
248 scm.find_checkout_root = lambda path: '' 248 scm.find_checkout_root = lambda path: ''
249 scm._run_git = lambda args: 'Date: 2013-02-08 08:05:49 +0000' 249 scm._run_git = lambda args: 'Date: 2013-02-08 08:05:49 +0000'
250 self.assertEqual(scm.timestamp_of_revision('some-path', '12345'), '2013- 02-08T08:05:49Z') 250 self.assertEqual(scm.timestamp_of_revision('some-path', '12345'), '2013- 02-08T08:05:49Z')
251 251
252 scm._run_git = lambda args: 'Date: 2013-02-08 01:02:03 +0130' 252 scm._run_git = lambda args: 'Date: 2013-02-08 01:02:03 +0130'
253 self.assertEqual(scm.timestamp_of_revision('some-path', '12345'), '2013- 02-07T23:32:03Z') 253 self.assertEqual(scm.timestamp_of_revision('some-path', '12345'), '2013- 02-07T23:32:03Z')
254 254
255 scm._run_git = lambda args: 'Date: 2013-02-08 01:55:21 -0800' 255 scm._run_git = lambda args: 'Date: 2013-02-08 01:55:21 -0800'
256 self.assertEqual(scm.timestamp_of_revision('some-path', '12345'), '2013- 02-08T09:55:21Z') 256 self.assertEqual(scm.timestamp_of_revision('some-path', '12345'), '2013- 02-08T09:55:21Z')
257
258 def test_get_issue_number(self):
259 scm = Git(cwd='.', executive=MockExecutive2(output='Issue number: 12345 (http://crrev.com/12345)'))
260 issue_number = scm.get_issue_number()
261 self.assertEqual(issue_number, '12345')
262 scm2 = Git(cwd='.', executive=MockExecutive2(output='Issue number: None (None)'))
263 issue_number = scm2.get_issue_number()
264 self.assertEqual(issue_number, 'None')
OLDNEW
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698