Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 2129613002: More accurate render time and continuous fresh (Closed)

Created:
4 years, 5 months ago by liyuqian
Modified:
4 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

More accurate render time and continuous fresh BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2129613002 Committed: https://skia.googlesource.com/skia/+/2edb0f4a02fd1dbb8d6cb628b84048bcc875f72f

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove ms argument of onIdle function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -42 lines) Patch
M platform_tools/android/apps/viewer/src/main/java/org/skia/viewer/StateAdapter.java View 2 chunks +5 lines, -0 lines 0 comments Download
M tools/viewer/Viewer.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M tools/viewer/Viewer.cpp View 1 6 chunks +17 lines, -8 lines 0 comments Download
M tools/viewer/sk_app/Application.h View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/viewer/sk_app/android/main_android.cpp View 1 3 chunks +1 line, -8 lines 0 comments Download
M tools/viewer/sk_app/android/surface_glue_android.cpp View 1 3 chunks +1 line, -8 lines 0 comments Download
M tools/viewer/sk_app/unix/main_unix.cpp View 1 3 chunks +1 line, -8 lines 0 comments Download
M tools/viewer/sk_app/win/main_win.cpp View 1 2 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
liyuqian
This is the feature that Greg wanted.
4 years, 5 months ago (2016-07-06 15:23:16 UTC) #4
jvanverth1
https://codereview.chromium.org/2129613002/diff/1/tools/viewer/Viewer.cpp File tools/viewer/Viewer.cpp (right): https://codereview.chromium.org/2129613002/diff/1/tools/viewer/Viewer.cpp#newcode494 tools/viewer/Viewer.cpp:494: void Viewer::onIdle(double ms) { We don't need the ms ...
4 years, 5 months ago (2016-07-06 15:27:20 UTC) #5
liyuqian
ms parameter is removed thanks to Jim's comment. https://codereview.chromium.org/2129613002/diff/1/tools/viewer/Viewer.cpp File tools/viewer/Viewer.cpp (right): https://codereview.chromium.org/2129613002/diff/1/tools/viewer/Viewer.cpp#newcode494 tools/viewer/Viewer.cpp:494: void ...
4 years, 5 months ago (2016-07-06 15:54:41 UTC) #6
jvanverth1
lgtm
4 years, 5 months ago (2016-07-06 20:18:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2129613002/20001
4 years, 5 months ago (2016-07-06 20:47:20 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 21:11:35 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/2edb0f4a02fd1dbb8d6cb628b84048bcc875f72f

Powered by Google App Engine
This is Rietveld 408576698