Issue 212953010: Revert of Always list EthernetEAP as a Favorite for debugging

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 212953010: Revert of Always list EthernetEAP as a Favorite for debugging (Closed)

Created:
6 years, 9 months ago by erikchen

Modified:
6 years, 9 months ago

Reviewers:
stevenjb, pneubeck (no reviews)

CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Revert of Always list EthernetEAP as a Favorite for debugging (https://codereview.chromium.org/210433002/) Reason for revert: chrome_os unittest failures: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/41308 Original issue's description: > Always list EthernetEAP as a Favorite for debugging > > Because EthernetEAP is never a visible service, we do not observe it. > When it is first created, no properties (including Profile) are set, so > it does not appear in the 'Favorite' list and as a result never gets > updated. This currently only affects debugging. > > As a workaround, we always treat EthernetEAP networks as a Favorite, > eveb if Profile is empty. > > BUG=355117 > R=pneubeck@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259682 TBR=pneubeck@chromium.org,stevenjb@chromium.org NOTREECHECKS=true NOTRY=true BUG=355117 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259714

Created: 6 years, 9 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -42 lines)			Patch
M	chromeos/network/favorite_state.h	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	chromeos/network/favorite_state.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	chromeos/network/managed_state.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chromeos/network/managed_state.cc	View	2 chunks	+1 line, -14 lines	0 comments	Download
M	chromeos/network/network_state_handler.cc	View	6 chunks	+8 lines, -9 lines	0 comments	Download
M	chromeos/network/shill_property_handler.cc	View	3 chunks	+3 lines, -6 lines	0 comments	Download

Total messages: 3 (0 generated)

erikchen

Created Revert of Always list EthernetEAP as a Favorite for debugging

6 years, 9 months ago (2014-03-26 22:00:06 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikchen@chromium.org/212953010/1

6 years, 9 months ago (2014-03-26 22:01:33 UTC) #2

Message was sent while issue was closed.

Change committed as 259714