Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8404)

Unified Diff: chromeos/network/shill_property_handler.cc

Issue 212953010: Revert of Always list EthernetEAP as a Favorite for debugging (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/network/network_state_handler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/network/shill_property_handler.cc
diff --git a/chromeos/network/shill_property_handler.cc b/chromeos/network/shill_property_handler.cc
index 8ae24fbb83c1fccca81a2ca9b653b3f2d13e0bad..5a4bca0f540f713aad739a0a13de7f2616eeee70 100644
--- a/chromeos/network/shill_property_handler.cc
+++ b/chromeos/network/shill_property_handler.cc
@@ -201,10 +201,10 @@
void ShillPropertyHandler::RequestProperties(ManagedState::ManagedType type,
const std::string& path) {
+ VLOG(2) << "Request Properties: " << type << " : " << path;
if (pending_updates_[type].find(path) != pending_updates_[type].end())
return; // Update already requested.
- NET_LOG_DEBUG("Request Properties", path);
pending_updates_[type].insert(path);
if (type == ManagedState::MANAGED_TYPE_NETWORK ||
type == ManagedState::MANAGED_TYPE_FAVORITE) {
@@ -344,9 +344,7 @@
std::set<std::string>& requested_service_updates =
requested_updates_[ManagedState::MANAGED_TYPE_NETWORK]; // For favorites
std::set<std::string> new_requested_updates;
- NET_LOG_DEBUG(
- base::StringPrintf("UpdateProperties: %" PRIuS, entries.GetSize()),
- ManagedState::TypeToString(type));
+ VLOG(2) << "Update Properties: " << type << " Entries: " << entries.GetSize();
for (base::ListValue::const_iterator iter = entries.begin();
iter != entries.end(); ++iter) {
std::string path;
@@ -467,8 +465,7 @@
const std::string& path,
DBusMethodCallStatus call_status,
const base::DictionaryValue& properties) {
- NET_LOG_DEBUG("GetPropertiesCallback: " + ManagedState::TypeToString(type),
- path);
+ VLOG(2) << "GetPropertiesCallback: " << type << " : " << path;
pending_updates_[type].erase(path);
if (call_status != DBUS_METHOD_CALL_SUCCESS) {
// The shill service no longer exists. This can happen when a network
« no previous file with comments | « chromeos/network/network_state_handler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698