Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 212953007: Control DirectWrite from browser side, no RuntimeEnabledFeature any more. (Closed)

Created:
6 years, 8 months ago by scottmg
Modified:
6 years, 8 months ago
Reviewers:
jschuh, jam, eae
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Control DirectWrite from browser side, no RuntimeEnabledFeature any more. Also, fix DirectWrite when --no-sandbox. Needs to roll https://codereview.chromium.org/210243004 and needs to land before https://codereview.chromium.org/213173003 R=jschuh@chromium.org,jam@chromium.org BUG=333029 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260015

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : fix no-sandbox #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -10 lines) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/child/runtime_features.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M content/common/sandbox_win.cc View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/renderer_main_platform_delegate_win.cc View 1 2 4 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 43 (0 generated)
scottmg
6 years, 8 months ago (2014-03-26 19:30:12 UTC) #1
scottmg
jschuh: content\common\sandbox_win.cc jam: content\browser\renderer_host\render_process_host_impl.cc content\child\runtime_features.cc content\renderer\renderer_main_platform_delegate_win.cc
6 years, 8 months ago (2014-03-26 23:36:11 UTC) #2
scottmg
6 years, 8 months ago (2014-03-26 23:36:33 UTC) #3
jschuh
lgtm
6 years, 8 months ago (2014-03-26 23:41:13 UTC) #4
eae
This is the roll in question https://codereview.chromium.org/214003002
6 years, 8 months ago (2014-03-27 00:31:59 UTC) #5
eae
The CQ bit was checked by eae@chromium.org
6 years, 8 months ago (2014-03-27 16:11:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/212953007/60001
6 years, 8 months ago (2014-03-27 16:11:12 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-27 16:34:17 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_rel
6 years, 8 months ago (2014-03-27 16:34:21 UTC) #9
eae
The CQ bit was checked by eae@chromium.org
6 years, 8 months ago (2014-03-27 16:35:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/212953007/60001
6 years, 8 months ago (2014-03-27 16:37:07 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-27 16:37:29 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_clang_dbg tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-03-27 16:37:30 UTC) #13
eae
The CQ bit was checked by eae@chromium.org
6 years, 8 months ago (2014-03-27 16:40:01 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/212953007/60001
6 years, 8 months ago (2014-03-27 16:42:02 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-27 16:45:20 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg
6 years, 8 months ago (2014-03-27 16:45:20 UTC) #17
eae
The CQ bit was checked by eae@chromium.org
6 years, 8 months ago (2014-03-27 16:45:49 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/212953007/60001
6 years, 8 months ago (2014-03-27 16:47:15 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-27 16:59:46 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_clang_dbg
6 years, 8 months ago (2014-03-27 16:59:47 UTC) #21
eae
The CQ bit was checked by eae@chromium.org
6 years, 8 months ago (2014-03-27 17:00:53 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/212953007/60001
6 years, 8 months ago (2014-03-27 17:02:00 UTC) #23
scottmg
On 2014/03/27 17:00:53, eae wrote: > The CQ bit was checked by mailto:eae@chromium.org The CQ ...
6 years, 8 months ago (2014-03-27 17:05:50 UTC) #24
eae
On 2014/03/27 17:05:50, scottmg wrote: > On 2014/03/27 17:00:53, eae wrote: > > The CQ ...
6 years, 8 months ago (2014-03-27 17:07:25 UTC) #25
jam
lgtm
6 years, 8 months ago (2014-03-27 17:07:31 UTC) #26
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-27 17:10:00 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-03-27 17:10:00 UTC) #28
eae
The CQ bit was checked by eae@chromium.org
6 years, 8 months ago (2014-03-27 17:32:56 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/212953007/60001
6 years, 8 months ago (2014-03-27 17:33:21 UTC) #30
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-27 17:43:35 UTC) #31
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_rel
6 years, 8 months ago (2014-03-27 17:43:36 UTC) #32
eae
The CQ bit was checked by eae@chromium.org
6 years, 8 months ago (2014-03-27 17:45:02 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/212953007/60001
6 years, 8 months ago (2014-03-27 17:45:29 UTC) #34
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-27 20:07:01 UTC) #35
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=289609
6 years, 8 months ago (2014-03-27 20:07:01 UTC) #36
eae
The CQ bit was checked by eae@chromium.org
6 years, 8 months ago (2014-03-27 20:11:35 UTC) #37
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/212953007/60001
6 years, 8 months ago (2014-03-27 20:11:58 UTC) #38
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-27 22:31:27 UTC) #39
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 8 months ago (2014-03-27 22:31:27 UTC) #40
eae
The CQ bit was checked by eae@chromium.org
6 years, 8 months ago (2014-03-27 22:33:08 UTC) #41
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/212953007/60001
6 years, 8 months ago (2014-03-27 22:34:01 UTC) #42
commit-bot: I haz the power
6 years, 8 months ago (2014-03-27 22:36:05 UTC) #43
Message was sent while issue was closed.
Change committed as 260015

Powered by Google App Engine
This is Rietveld 408576698