|
|
Created:
6 years, 8 months ago by scottmg Modified:
6 years, 8 months ago CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
DescriptionControl DirectWrite from browser side, no RuntimeEnabledFeature any more.
Also, fix DirectWrite when --no-sandbox.
Needs to roll https://codereview.chromium.org/210243004
and needs to land before https://codereview.chromium.org/213173003
R=jschuh@chromium.org,jam@chromium.org
BUG=333029
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260015
Patch Set 1 #Patch Set 2 : . #Patch Set 3 : . #Patch Set 4 : fix no-sandbox #
Messages
Total messages: 43 (0 generated)
jschuh: content\common\sandbox_win.cc jam: content\browser\renderer_host\render_process_host_impl.cc content\child\runtime_features.cc content\renderer\renderer_main_platform_delegate_win.cc
lgtm
This is the roll in question https://codereview.chromium.org/214003002
The CQ bit was checked by eae@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/212953007/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.chromium on linux_chromium_rel
The CQ bit was checked by eae@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/212953007/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_clang_dbg tryserver.chromium on linux_chromium_chromeos_rel
The CQ bit was checked by eae@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/212953007/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg
The CQ bit was checked by eae@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/212953007/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_clang_dbg
The CQ bit was checked by eae@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/212953007/60001
On 2014/03/27 17:00:53, eae wrote: > The CQ bit was checked by mailto:eae@chromium.org The CQ is all f'd, but it needs jam@s review first anyway to pass presubmit.
On 2014/03/27 17:05:50, scottmg wrote: > On 2014/03/27 17:00:53, eae wrote: > > The CQ bit was checked by mailto:eae@chromium.org > > The CQ is all f'd, but it needs jam@s review first anyway to pass presubmit. Hopefully be the time he reviews it it'll have passed all the other bots.
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
The CQ bit was checked by eae@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/212953007/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.chromium on linux_chromium_rel
The CQ bit was checked by eae@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/212953007/60001
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on win_rel for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...
The CQ bit was checked by eae@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/212953007/60001
The CQ bit was unchecked by commit-bot@chromium.org
Commit queue rejected this change because the description was changed between the time the change entered the commit queue and the time it was ready to commit. You can safely check the commit box again.
The CQ bit was checked by eae@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/212953007/60001
Message was sent while issue was closed.
Change committed as 260015 |