Usage of DirectWrite now determined browser-side

Usage of DirectWrite now determined browser-side

Enabling DirectWrite requires the sandbox to have knowledge of whether
DirectWrite or GDI is used for font rendering, so it's now decided
in the browser. Don't do fallback behavior in the renderer any more.

Browser side is https://codereview.chromium.org/209163002/ .

R=jamesr@chromium.org
BUG=333029
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170075

[scottmg, 2014-03-25 21:44:21]

eae says this shouldn't be a RuntimeEnabledFeature any longer, as Blink can't
freely set it. I'm reworking now to have it set up in a different way.

[scottmg, 2014-03-25 22:12:06]

Something like this?

[eae, 2014-03-25 22:14:49]

Yeah, exactly what I had in mind.

Thanks

LGTM

https://codereview.chromium.org/210243004/diff/50001/Source/platform/fonts/wi...
File Source/platform/fonts/win/FontCacheSkiaWin.cpp (right):

https://codereview.chromium.org/210243004/diff/50001/Source/platform/fonts/wi...
Source/platform/fonts/win/FontCacheSkiaWin.cpp:57: 
ASSERT(fontManager);

[scottmg, 2014-03-25 22:21:56]

Thanks.

It's complaining about

You added one or more #includes that violate checkdeps rules.
  public\web\win\WebFontRendering.h
      Illegal include: "../../platform/WebCommon.h"
    Because of no rule applying.

which I need for BLINK_EXPORT. Is that actually against the rules or the wrong
way to get that?

https://codereview.chromium.org/210243004/diff/50001/Source/platform/fonts/wi...
File Source/platform/fonts/win/FontCacheSkiaWin.cpp (right):

https://codereview.chromium.org/210243004/diff/50001/Source/platform/fonts/wi...
Source/platform/fonts/win/FontCacheSkiaWin.cpp:57: 
On 2014/03/25 22:14:49, eae wrote:
> ASSERT(fontManager);

Done.

[eae, 2014-03-25 22:26:04]

On 2014/03/25 22:21:56, scottmg wrote:
> Thanks.
> 
> It's complaining about
> 
> You added one or more #includes that violate checkdeps rules.
>   public\web\win\WebFontRendering.h
>       Illegal include: "../../platform/WebCommon.h"
>     Because of no rule applying.
> 
> which I need for BLINK_EXPORT. Is that actually against the rules or the wrong
> way to get that?

Try #include "public/platform/WebCommon.h" instead?

[scottmg, 2014-03-25 22:56:28]

dglazkov or jamesr can you stamp for these?

Missing OWNER reviewers for these files:
    Source\web\web.gypi
    Source\web\win\WebFontRendering.cpp
    public\web\win\WebFontRendering.h

[scottmg, 2014-03-26 02:40:04]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2014-03-26 02:40:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scottmg@chromium.org/210243004/190001

[commit-bot: I haz the power, 2014-03-26 02:49:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-26 02:49:25]

Try jobs failed on following builders:
  tryserver.blink on blink_presubmit

[eae, 2014-03-26 15:42:13]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2014-03-26 15:42:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scottmg@chromium.org/210243004/190001

[commit-bot: I haz the power, 2014-03-26 15:54:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-26 15:54:30]

Try jobs failed on following builders:
  tryserver.blink on blink_presubmit

[dglazkov, 2014-03-26 16:03:32]

lgtm

[commit-bot: I haz the power, 2014-03-26 16:03:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scottmg@chromium.org/210243004/190001

[commit-bot: I haz the power, 2014-03-26 17:55:49]

Change committed as 170075