Compile Vulkan when building for the Android framework.

Compile Vulkan when building for the Android framework.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2129523002

Committed: https://skia.googlesource.com/skia/+/d5fd2ff49067efebcd7e28fdc787ec21b2176152

[djsollen, 2016-07-06 13:48:05]

Description was changed from

==========
Compile Vulkan when building for the Android framework.
==========

to

==========
Compile Vulkan when building for the Android framework.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2129523002
==========

[djsollen, 2016-07-06 13:48:26]

The CQ bit was checked by djsollen@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-06 13:48:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[djsollen, 2016-07-06 14:36:10]

The CQ bit was checked by djsollen@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-06 14:36:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[djsollen, 2016-07-06 14:36:34]

djsollen@google.com changed reviewers:
+ egdaniel@google.com, ethannicholas@google.com

[commit-bot: I haz the power, 2016-07-06 14:56:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-06 14:56:33]

Dry run: This issue passed the CQ dry run.

[egdaniel, 2016-07-06 15:21:05]

https://codereview.chromium.org/2129523002/diff/40001/gyp/common_variables.gypi
File gyp/common_variables.gypi (right):

https://codereview.chromium.org/2129523002/diff/40001/gyp/common_variables.gy...
gyp/common_variables.gypi:85: 'skia_vulkan%': 1,
will anywhere we build with skia_android_framework have vulkan?

https://codereview.chromium.org/2129523002/diff/40001/gyp/gpu.gyp
File gyp/gpu.gyp (right):

https://codereview.chromium.org/2129523002/diff/40001/gyp/gpu.gyp#newcode91
gyp/gpu.gyp:91: 'shaderc.gyp:shaderc_combined',
should this not be under the skia_vulkan section?

[egdaniel, 2016-07-06 15:30:09]

On 2016/07/06 15:21:05, egdaniel wrote:
>
https://codereview.chromium.org/2129523002/diff/40001/gyp/common_variables.gypi
> File gyp/common_variables.gypi (right):
> 
>
https://codereview.chromium.org/2129523002/diff/40001/gyp/common_variables.gy...
> gyp/common_variables.gypi:85: 'skia_vulkan%': 1,
> will anywhere we build with skia_android_framework have vulkan?
> 
> https://codereview.chromium.org/2129523002/diff/40001/gyp/gpu.gyp
> File gyp/gpu.gyp (right):
> 
> https://codereview.chromium.org/2129523002/diff/40001/gyp/gpu.gyp#newcode91
> gyp/gpu.gyp:91: 'shaderc.gyp:shaderc_combined',
> should this not be under the skia_vulkan section?

lgtm once we drop the shaderc dependency into the vulkan condition

[djsollen, 2016-07-06 15:42:18]

https://codereview.chromium.org/2129523002/diff/40001/gyp/common_variables.gypi
File gyp/common_variables.gypi (right):

https://codereview.chromium.org/2129523002/diff/40001/gyp/common_variables.gy...
gyp/common_variables.gypi:85: 'skia_vulkan%': 1,
On 2016/07/06 15:21:04, egdaniel wrote:
> will anywhere we build with skia_android_framework have vulkan?

Yes

https://codereview.chromium.org/2129523002/diff/40001/gyp/gpu.gyp
File gyp/gpu.gyp (right):

https://codereview.chromium.org/2129523002/diff/40001/gyp/gpu.gyp#newcode91
gyp/gpu.gyp:91: 'shaderc.gyp:shaderc_combined',
On 2016/07/06 15:21:05, egdaniel wrote:
> should this not be under the skia_vulkan section?

Done.

[djsollen, 2016-07-06 15:42:37]

The CQ bit was checked by djsollen@google.com

[djsollen, 2016-07-06 15:42:38]

The patchset sent to the CQ was uploaded after l-g-t-m from egdaniel@google.com
Link to the patchset: https://codereview.chromium.org/2129523002/#ps60001
(title: "Compile Vulkan when building for the Android framework.")

[commit-bot: I haz the power, 2016-07-06 15:42:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-06 16:17:38]

Description was changed from

==========
Compile Vulkan when building for the Android framework.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2129523002
==========

to

==========
Compile Vulkan when building for the Android framework.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2129523002

Committed:
https://skia.googlesource.com/skia/+/d5fd2ff49067efebcd7e28fdc787ec21b2176152
==========

[commit-bot: I haz the power, 2016-07-06 16:17:39]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/d5fd2ff49067efebcd7e28fdc787ec21b2176152