|
|
Don't dynamically scope GN templates.
Implement defined() for accessors so you can say defined(invoker.bar)
Implement a MakeClosure() function on Scope for cloning and flattening the variables in a scope for later use.
A new Template class that tracks both the template code and the closure information.
Hooking up the new template class to where we use templates.
R=scottmg@chromium.org, scottmg
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259991
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+524 lines, -152 lines) |
Patch |
 |
M |
tools/gn/BUILD.gn
|
View
|
|
2 chunks |
+3 lines, -0 lines |
0 comments
|
Download
|
|
M |
tools/gn/function_set_defaults.cc
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
tools/gn/function_template.cc
|
View
|
|
3 chunks |
+93 lines, -33 lines |
0 comments
|
Download
|
|
M |
tools/gn/functions.cc
|
View
|
|
5 chunks |
+54 lines, -53 lines |
0 comments
|
Download
|
|
A |
tools/gn/functions_unittest.cc
|
View
|
|
1 chunk |
+55 lines, -0 lines |
0 comments
|
Download
|
|
M |
tools/gn/gn.gyp
|
View
|
|
2 chunks |
+3 lines, -0 lines |
0 comments
|
Download
|
|
M |
tools/gn/import_manager.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
tools/gn/scope.h
|
View
|
|
5 chunks |
+21 lines, -10 lines |
0 comments
|
Download
|
|
M |
tools/gn/scope.cc
|
View
|
|
6 chunks |
+95 lines, -50 lines |
0 comments
|
Download
|
|
M |
tools/gn/scope_unittest.cc
|
View
|
|
3 chunks |
+71 lines, -4 lines |
0 comments
|
Download
|
|
A |
tools/gn/template.h
|
View
|
|
1 chunk |
+53 lines, -0 lines |
0 comments
|
Download
|
|
A |
tools/gn/template.cc
|
View
|
|
1 chunk |
+73 lines, -0 lines |
0 comments
|
Download
|
Total messages: 3 (0 generated)
|
Chromium Code Reviews
Issue
212933008:
Don't dynamically scope GN templates. (Closed)
