tools/gn/import_manager.cc - Issue 212933008: Don't dynamically scope GN templates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/import_manager.cc

Issue 212933008: Don't dynamically scope GN templates. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/import_manager.cc

diff --git a/tools/gn/import_manager.cc b/tools/gn/import_manager.cc

index 0d87942e1803ab1e8ec803de96971fd1a350d686..2e8293ed7cff7071459aa733be4af6b1ba31d1e3 100644

--- a/tools/gn/import_manager.cc

+++ b/tools/gn/import_manager.cc

@@ -81,6 +81,6 @@ bool ImportManager::DoImport(const SourceFile& file,

}

- return imported_scope->NonRecursiveMergeTo(scope, node_for_err,

+ return imported_scope->NonRecursiveMergeTo(scope, false, node_for_err,

"import", err);

}

« no previous file with comments | « tools/gn/gn.gyp ('k') | tools/gn/scope.h » ('j') | no next file with comments »