Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 212933002: Actually identify required saveLayers in SkGpuDevice::EXPERIMENTAL_drawPicture (Closed)

Created:
6 years, 9 months ago by robertphillips
Modified:
6 years, 8 months ago
Reviewers:
bsalomon, rmistry
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Actually identify required saveLayers in SkGpuDevice::EXPERIMENTAL_drawPicture NOTRY=true Committed: http://code.google.com/p/skia/source/detail?r=13993

Patch Set 1 #

Patch Set 2 : cleaned up #

Total comments: 2

Patch Set 3 : Addressed code review issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+401 lines, -32 lines) Patch
M gyp/gpu.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M include/core/SkDevice.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M include/gpu/GrClipData.h View 1 2 2 chunks +8 lines, -1 line 0 comments Download
M include/gpu/SkGpuDevice.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkCanvas.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkDevice.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrClipData.cpp View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
A src/gpu/GrPictureUtils.h View 1 1 chunk +55 lines, -0 lines 0 comments Download
A src/gpu/GrPictureUtils.cpp View 1 1 chunk +247 lines, -0 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 2 3 chunks +70 lines, -13 lines 0 comments Download
M tools/PictureRenderer.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M tools/PictureRenderer.cpp View 1 2 6 chunks +7 lines, -10 lines 0 comments Download
M tools/render_pictures_main.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
robertphillips
6 years, 9 months ago (2014-03-26 14:17:32 UTC) #1
bsalomon
lgtm https://codereview.chromium.org/212933002/diff/20001/tools/PictureRenderer.cpp File tools/PictureRenderer.cpp (right): https://codereview.chromium.org/212933002/diff/20001/tools/PictureRenderer.cpp#newcode498 tools/PictureRenderer.cpp:498: fPicture = pict; could be fPicture = SkRef(pict);
6 years, 9 months ago (2014-03-26 17:29:20 UTC) #2
robertphillips
https://codereview.chromium.org/212933002/diff/20001/tools/PictureRenderer.cpp File tools/PictureRenderer.cpp (right): https://codereview.chromium.org/212933002/diff/20001/tools/PictureRenderer.cpp#newcode498 tools/PictureRenderer.cpp:498: fPicture = pict; On 2014/03/26 17:29:21, bsalomon wrote: > ...
6 years, 9 months ago (2014-03-28 11:48:16 UTC) #3
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 8 months ago (2014-03-31 16:31:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/212933002/50001
6 years, 8 months ago (2014-03-31 16:31:31 UTC) #5
rmistry
On 2014/03/31 16:31:31, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 8 months ago (2014-03-31 17:37:46 UTC) #6
rmistry
The CQ bit was unchecked by rmistry@google.com
6 years, 8 months ago (2014-03-31 17:40:53 UTC) #7
rmistry
The CQ bit was checked by rmistry@google.com
6 years, 8 months ago (2014-03-31 17:41:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/212933002/50001
6 years, 8 months ago (2014-03-31 17:41:54 UTC) #9
robertphillips
The CQ bit was unchecked by robertphillips@google.com
6 years, 8 months ago (2014-03-31 17:54:06 UTC) #10
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 8 months ago (2014-03-31 17:54:16 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/212933002/50001
6 years, 8 months ago (2014-03-31 17:54:25 UTC) #12
commit-bot: I haz the power
6 years, 8 months ago (2014-03-31 17:55:37 UTC) #13
Message was sent while issue was closed. 
Change committed as 13993

Powered by Google App Engine
This is Rietveld 408576698