Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 2129323002: Remove self._builder_data from Rebaseline classes. (Closed)

Created:
4 years, 5 months ago by qyearsley
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke, wkorman
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove self._builder_data from Rebaseline classes. This is a preliminary refactoring change to try to make it easier to change _suffixes_for_actual_failures to give results for try jobs, in order to enable http://crrev.com/2118513002 to work. Committed: https://crrev.com/dccba930ed20e84ed5208f1ec3d5ad10efaf91f0 Cr-Commit-Position: refs/heads/master@{#404822}

Patch Set 1 #

Patch Set 2 : Remove all reformatting changes -- will do those in a separate CL. #

Patch Set 3 : Remove print statement #

Patch Set 4 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -50 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py View 1 chunk +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py View 1 2 3 25 chunks +36 lines, -40 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
qyearsley
4 years, 5 months ago (2016-07-11 16:59:38 UTC) #2
wkorman
lgtm
4 years, 5 months ago (2016-07-11 18:02:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2129323002/60001
4 years, 5 months ago (2016-07-12 17:59:39 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-12 19:37:04 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-12 19:38:22 UTC) #12
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/dccba930ed20e84ed5208f1ec3d5ad10efaf91f0 Cr-Commit-Position: refs/heads/master@{#404822}
4 years, 5 months ago (2016-07-12 19:38:48 UTC) #14
Dirk Pranke
4 years, 4 months ago (2016-08-09 03:48:35 UTC) #15
Message was sent while issue was closed.
lgtm (very belatedly).

Powered by Google App Engine
This is Rietveld 408576698