Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1175)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py

Issue 2129323002: Remove self._builder_data from Rebaseline classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
index 77424eec001d20a2fb320cde0bfeca53be876046..49c113fa6d9799660f151b594fc818842e3ebdd1 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
@@ -285,18 +285,18 @@ class AbstractParallelRebaselineCommand(AbstractRebaseliningCommand):
def __init__(self, options=None):
super(AbstractParallelRebaselineCommand, self).__init__(options=options)
- self._builder_data = {}
+ @memoized
def builder_data(self):
- if not self._builder_data:
- for builder_name in self._release_builders():
- builder = self._tool.buildbot.builder_with_name(builder_name)
- builder_results = builder.latest_layout_test_results()
- if builder_results:
- self._builder_data[builder_name] = builder_results
- else:
- raise Exception("No result for builder %s." % builder_name)
- return self._builder_data
+ builder_to_results = {}
+ for builder_name in self._release_builders():
+ builder = self._tool.buildbot.builder_with_name(builder_name)
+ builder_results = builder.latest_layout_test_results()
+ if builder_results:
+ builder_to_results[builder_name] = builder_results
+ else:
+ raise Exception("No result for builder %s." % builder_name)
+ return builder_to_results
# The release builders cycle much faster than the debug ones and cover all the platforms.
def _release_builders(self):
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698