Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 2137453003: mac: Remove IsOSMavericksOrLater() (Closed)

Created:
4 years, 5 months ago by Mark Mentovai
Modified:
4 years, 5 months ago
Reviewers:
erikchen, Nico, brettw
CC:
chromium-reviews, posciak+watch_chromium.org, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@cfallocator_1012
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mac: Remove IsOSMavericksOrLater() BUG=579255 R=erikchen@chromium.org,thakis@chromium.org TBR=brettw@chromium.org Committed: https://crrev.com/dd7e82fd7545f045e1eb2b5c99a3cd88381257a2 Cr-Commit-Position: refs/heads/master@{#404534}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -158 lines) Patch
M base/mac/mac_util.h View 2 chunks +0 lines, -7 lines 0 comments Download
M base/mac/mac_util.mm View 1 chunk +0 lines, -6 lines 0 comments Download
M base/mac/mac_util_unittest.mm View 4 chunks +0 lines, -4 lines 0 comments Download
M base/process/memory_unittest.cc View 3 chunks +0 lines, -15 lines 0 comments Download
M base/process/process_util_unittest.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/platform_util_mac.mm View 2 chunks +9 lines, -100 lines 0 comments Download
M content/app/mac/mac_init.mm View 2 chunks +1 line, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_view_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M media/gpu/vt_video_encode_accelerator_mac.cc View 3 chunks +0 lines, -11 lines 0 comments Download
M ui/base/cocoa/remote_layer_api.mm View 3 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
Mark Mentovai
We’re always Mavericks or later. We’re also always 64-bit.
4 years, 5 months ago (2016-07-08 18:29:19 UTC) #2
erikchen
lgtm
4 years, 5 months ago (2016-07-08 18:31:25 UTC) #3
Nico
lgtm, thanks! https://codereview.chromium.org/2137453003/diff/1/content/app/mac/mac_init.mm File content/app/mac/mac_init.mm (right): https://codereview.chromium.org/2137453003/diff/1/content/app/mac/mac_init.mm#newcode27 content/app/mac/mac_init.mm:27: // TODO: Remove this when we build ...
4 years, 5 months ago (2016-07-08 18:32:39 UTC) #4
Mark Mentovai
https://codereview.chromium.org/2137453003/diff/1/content/app/mac/mac_init.mm File content/app/mac/mac_init.mm (right): https://codereview.chromium.org/2137453003/diff/1/content/app/mac/mac_init.mm#newcode27 content/app/mac/mac_init.mm:27: // TODO: Remove this when we build with the ...
4 years, 5 months ago (2016-07-08 18:38:42 UTC) #5
Mark Mentovai
brett for OWNERS
4 years, 5 months ago (2016-07-08 20:21:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2137453003/20001
4 years, 5 months ago (2016-07-08 20:22:08 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-08 23:41:38 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 23:41:50 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 23:43:35 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dd7e82fd7545f045e1eb2b5c99a3cd88381257a2
Cr-Commit-Position: refs/heads/master@{#404534}

Powered by Google App Engine
This is Rietveld 408576698