DescriptionPrevent ctrl+wheel from scrolling in more places
Chromium now sends ctrl+wheel events to webkit first before using them for zooming. Rather than prevent scrolling for these events in EventHandler::handleWheel, push that check a couple levels deeper into ScrollableArea::handleWheelEvent. In addition to EventHandler, this code is also called by WebPluginScrollbarImpl and so will fix some additional cases.
This is mostly already tested by the fast/event/wheelevent-ctrl.html test I added in http://crrev.com/183403002. I've extended that test to cover document and div scrolling cases and ensured it fails reliably if either the ScrollableArea or EventHandler::defaultWheelEventHandler check is removed.
BUG=352474, 111059
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170238
Patch Set 1 #
Total comments: 1
Patch Set 2 : Fixes #
Messages
Total messages: 17 (0 generated)
|