Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2129083002: Explicitly check various sync_file_system classes live on the IO thread. (Closed)

Created:
4 years, 5 months ago by Lei Zhang
Modified:
4 years, 5 months ago
Reviewers:
tzik
CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Explicitly check various sync_file_system classes live on the IO thread. Committed: https://crrev.com/c7292a989c6c0a6d71d2b3a4c72b49d632ca62c2 Cr-Commit-Position: refs/heads/master@{#404607}

Patch Set 1 #

Patch Set 2 : fix tests #

Total comments: 2

Patch Set 3 : rebase #

Patch Set 4 : fix tests, remove unneeded check #

Messages

Total messages: 11 (3 generated)
Lei Zhang
4 years, 5 months ago (2016-07-08 04:59:01 UTC) #2
tzik
https://codereview.chromium.org/2129083002/diff/20001/chrome/browser/sync_file_system/local/local_file_change_tracker_unittest.cc File chrome/browser/sync_file_system/local/local_file_change_tracker_unittest.cc (right): https://codereview.chromium.org/2129083002/diff/20001/chrome/browser/sync_file_system/local/local_file_change_tracker_unittest.cc#newcode42 chrome/browser/sync_file_system/local/local_file_change_tracker_unittest.cc:42: : in_memory_env_(leveldb::NewMemEnv(leveldb::Env::Default())), Could you add below here for test ...
4 years, 5 months ago (2016-07-11 05:32:57 UTC) #3
Lei Zhang
https://codereview.chromium.org/2129083002/diff/20001/chrome/browser/sync_file_system/local/local_file_change_tracker_unittest.cc File chrome/browser/sync_file_system/local/local_file_change_tracker_unittest.cc (right): https://codereview.chromium.org/2129083002/diff/20001/chrome/browser/sync_file_system/local/local_file_change_tracker_unittest.cc#newcode42 chrome/browser/sync_file_system/local/local_file_change_tracker_unittest.cc:42: : in_memory_env_(leveldb::NewMemEnv(leveldb::Env::Default())), On 2016/07/11 05:32:57, tzik wrote: > Could ...
4 years, 5 months ago (2016-07-11 05:56:47 UTC) #4
tzik
lgtm
4 years, 5 months ago (2016-07-11 05:57:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2129083002/60001
4 years, 5 months ago (2016-07-11 06:11:53 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-11 06:34:45 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-11 06:34:51 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 06:36:34 UTC) #11
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/c7292a989c6c0a6d71d2b3a4c72b49d632ca62c2
Cr-Commit-Position: refs/heads/master@{#404607}

Powered by Google App Engine
This is Rietveld 408576698