Explicitly check various sync_file_system classes live on the IO thread.

chrome/browser/sync_file_system/local/local_file_change_tracker_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync_file_system/local/local_file_change_tracker.h"
 
 #include <stdint.h>
 
 #include <deque>
 #include <memory>
 #include <set>
 
 #include "base/files/scoped_temp_dir.h"
 #include "base/macros.h"
-#include "base/message_loop/message_loop.h"
+#include "base/run_loop.h"
 #include "base/stl_util.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "chrome/browser/sync_file_system/local/canned_syncable_file_system.h"
 #include "chrome/browser/sync_file_system/local/local_file_sync_context.h"
 #include "chrome/browser/sync_file_system/local/sync_file_system_backend.h"
 #include "chrome/browser/sync_file_system/sync_status_code.h"
 #include "chrome/browser/sync_file_system/syncable_file_system_util.h"
 #include "content/public/test/mock_blob_url_request_context.h"
+#include "content/public/test/test_browser_thread_bundle.h"
 #include "storage/browser/fileapi/file_system_context.h"
 #include "storage/browser/quota/quota_manager.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/leveldatabase/src/helpers/memenv/memenv.h"
 #include "third_party/leveldatabase/src/include/leveldb/env.h"
 
+using content::MockBlobURLRequestContext;
+using content::ScopedTextBlob;
 using storage::FileSystemContext;
 using storage::FileSystemURL;
 using storage::FileSystemURLSet;
-using content::MockBlobURLRequestContext;
-using content::ScopedTextBlob;
 
 namespace sync_file_system {
 
 class LocalFileChangeTrackerTest : public testing::Test {
  public:
   LocalFileChangeTrackerTest()
-      : in_memory_env_(leveldb::NewMemEnv(leveldb::Env::Default())),
+      : thread_bundle_(content::TestBrowserThreadBundle::IO_MAINLOOP),
+        in_memory_env_(leveldb::NewMemEnv(leveldb::Env::Default())),
         file_system_(GURL("http://example.com"),
                      in_memory_env_.get(),
                      base::ThreadTaskRunnerHandle::Get().get(),
                      base::ThreadTaskRunnerHandle::Get().get()) {}
 
   void SetUp() override {
     file_system_.SetUp(CannedSyncableFileSystem::QUOTA_ENABLED);
 
     ASSERT_TRUE(base_dir_.CreateUniqueTempDir());
     sync_context_ =
         new LocalFileSyncContext(base_dir_.path(),
                                  in_memory_env_.get(),
                                  base::ThreadTaskRunnerHandle::Get().get(),
                                  base::ThreadTaskRunnerHandle::Get().get());
     ASSERT_EQ(
-        sync_file_system::SYNC_STATUS_OK,
+        SYNC_STATUS_OK,
         file_system_.MaybeInitializeFileSystemContext(sync_context_.get()));
   }
 
   void TearDown() override {
-    if (sync_context_.get())
-      sync_context_->ShutdownOnUIThread();
+    sync_context_->ShutdownOnUIThread();
     sync_context_ = nullptr;
 
-    message_loop_.RunUntilIdle();
+    base::RunLoop().RunUntilIdle();
     file_system_.TearDown();
     // Make sure we don't leave the external filesystem.
     // (CannedSyncableFileSystem::TearDown does not do this as there may be
     // multiple syncable file systems registered for the name)
     RevokeSyncableFileSystem();
   }
 
  protected:
   FileSystemURL URL(const std::string& path) {
     return file_system_.URL(path);
@@ skipping 28 matching lines @@
   }
 
   void RestoreChangesFromTrackerDB() {
     change_tracker()->CollectLastDirtyChanges(file_system_context());
   }
 
   void GetAllChangedURLs(storage::FileSystemURLSet* urls) {
     change_tracker()->GetAllChangedURLs(urls);
   }
 
-  base::MessageLoopForIO message_loop_;
+  content::TestBrowserThreadBundle thread_bundle_;
   base::ScopedTempDir base_dir_;
   std::unique_ptr<leveldb::Env> in_memory_env_;
   CannedSyncableFileSystem file_system_;
 
  private:
   scoped_refptr<LocalFileSyncContext> sync_context_;
 
   DISALLOW_COPY_AND_ASSIGN(LocalFileChangeTrackerTest);
 };
 
@@ skipping 117 matching lines @@
   EXPECT_EQ(URL(kPath3), urls_to_process[2]);
   EXPECT_EQ(URL(kPath5), urls_to_process[3]);
   EXPECT_EQ(URL(kPath4), urls_to_process[4]);
 
   // No changes to promote any more.
   EXPECT_FALSE(change_tracker()->PromoteDemotedChanges());
 
 
   VerifyAndClearChange(URL(kPath1),
                FileChange(FileChange::FILE_CHANGE_DELETE,
-                          sync_file_system::SYNC_FILE_TYPE_DIRECTORY));
+                          SYNC_FILE_TYPE_DIRECTORY));
   VerifyAndClearChange(URL(kPath2),
                FileChange(FileChange::FILE_CHANGE_ADD_OR_UPDATE,
-                          sync_file_system::SYNC_FILE_TYPE_DIRECTORY));
+                          SYNC_FILE_TYPE_DIRECTORY));
   VerifyAndClearChange(URL(kPath3),
                FileChange(FileChange::FILE_CHANGE_DELETE,
-                          sync_file_system::SYNC_FILE_TYPE_FILE));
+                          SYNC_FILE_TYPE_FILE));
   VerifyAndClearChange(URL(kPath4),
                FileChange(FileChange::FILE_CHANGE_ADD_OR_UPDATE,
-                          sync_file_system::SYNC_FILE_TYPE_FILE));
+                          SYNC_FILE_TYPE_FILE));
   VerifyAndClearChange(URL(kPath5),
                FileChange(FileChange::FILE_CHANGE_DELETE,
-                          sync_file_system::SYNC_FILE_TYPE_FILE));
+                          SYNC_FILE_TYPE_FILE));
 }
 
 TEST_F(LocalFileChangeTrackerTest, RestoreCreateAndModifyChanges) {
   EXPECT_EQ(base::File::FILE_OK, file_system_.OpenFileSystem());
 
   FileSystemURLSet urls;
 
   const char kPath0[] = "file a";
   const char kPath1[] = "dir a";
   const char kPath2[] = "dir a/dir";
@@ skipping 36 matching lines @@
   ASSERT_EQ(0U, urls.size());
 
   RestoreChangesFromTrackerDB();
 
   // Make sure the changes are restored from the DB.
   file_system_.GetChangedURLsInTracker(&urls);
   EXPECT_EQ(5U, urls.size());
 
   VerifyAndClearChange(URL(kPath0),
                        FileChange(FileChange::FILE_CHANGE_ADD_OR_UPDATE,
-                                  sync_file_system::SYNC_FILE_TYPE_FILE));
+                                  SYNC_FILE_TYPE_FILE));
   VerifyAndClearChange(URL(kPath1),
                        FileChange(FileChange::FILE_CHANGE_ADD_OR_UPDATE,
-                                  sync_file_system::SYNC_FILE_TYPE_DIRECTORY));
+                                  SYNC_FILE_TYPE_DIRECTORY));
   VerifyAndClearChange(URL(kPath2),
                        FileChange(FileChange::FILE_CHANGE_ADD_OR_UPDATE,
-                                  sync_file_system::SYNC_FILE_TYPE_DIRECTORY));
+                                  SYNC_FILE_TYPE_DIRECTORY));
   VerifyAndClearChange(URL(kPath3),
                        FileChange(FileChange::FILE_CHANGE_ADD_OR_UPDATE,
-                                  sync_file_system::SYNC_FILE_TYPE_FILE));
+                                  SYNC_FILE_TYPE_FILE));
   VerifyAndClearChange(URL(kPath4),
                        FileChange(FileChange::FILE_CHANGE_ADD_OR_UPDATE,
-                                  sync_file_system::SYNC_FILE_TYPE_FILE));
+                                  SYNC_FILE_TYPE_FILE));
 }
 
 TEST_F(LocalFileChangeTrackerTest, RestoreRemoveChanges) {
   EXPECT_EQ(base::File::FILE_OK, file_system_.OpenFileSystem());
 
   FileSystemURLSet urls;
 
   const char kPath0[] = "file";
   const char kPath1[] = "dir a";
   const char kPath2[] = "dir b";
@@ skipping 40 matching lines @@
   RestoreChangesFromTrackerDB();
 
   // Make sure the changes are restored from the DB.
   file_system_.GetChangedURLsInTracker(&urls);
   // Since directories to have been reverted (kPath1, kPath2, kPath4) are
   // treated as FILE_CHANGE_DELETE, the number of changes should be 6.
   EXPECT_EQ(6U, urls.size());
 
   VerifyAndClearChange(URL(kPath0),
                        FileChange(FileChange::FILE_CHANGE_DELETE,
-                                  sync_file_system::SYNC_FILE_TYPE_UNKNOWN));
+                                  SYNC_FILE_TYPE_UNKNOWN));
   VerifyAndClearChange(URL(kPath1),
                        FileChange(FileChange::FILE_CHANGE_DELETE,
-                                  sync_file_system::SYNC_FILE_TYPE_UNKNOWN));
+                                  SYNC_FILE_TYPE_UNKNOWN));
   VerifyAndClearChange(URL(kPath2),
                        FileChange(FileChange::FILE_CHANGE_DELETE,
-                                  sync_file_system::SYNC_FILE_TYPE_UNKNOWN));
+                                  SYNC_FILE_TYPE_UNKNOWN));
   VerifyAndClearChange(URL(kPath3),
                        FileChange(FileChange::FILE_CHANGE_DELETE,
-                                  sync_file_system::SYNC_FILE_TYPE_UNKNOWN));
+                                  SYNC_FILE_TYPE_UNKNOWN));
   VerifyAndClearChange(URL(kPath4),
                        FileChange(FileChange::FILE_CHANGE_DELETE,
-                                  sync_file_system::SYNC_FILE_TYPE_UNKNOWN));
+                                  SYNC_FILE_TYPE_UNKNOWN));
   VerifyAndClearChange(URL(kPath5),
                        FileChange(FileChange::FILE_CHANGE_DELETE,
-                                  sync_file_system::SYNC_FILE_TYPE_UNKNOWN));
+                                  SYNC_FILE_TYPE_UNKNOWN));
 }
 
 TEST_F(LocalFileChangeTrackerTest, RestoreCopyChanges) {
   EXPECT_EQ(base::File::FILE_OK, file_system_.OpenFileSystem());
 
   FileSystemURLSet urls;
 
   const char kPath0[] = "file a";
   const char kPath1[] = "dir a";
   const char kPath2[] = "dir a/dir";
@@ skipping 58 matching lines @@
   ASSERT_EQ(0U, urls.size());
 
   RestoreChangesFromTrackerDB();
 
   // Make sure the changes are restored from the DB.
   file_system_.GetChangedURLsInTracker(&urls);
   EXPECT_EQ(5U, urls.size());
 
   VerifyAndClearChange(URL(kPath0Copy),
                        FileChange(FileChange::FILE_CHANGE_ADD_OR_UPDATE,
-                                  sync_file_system::SYNC_FILE_TYPE_FILE));
+                                  SYNC_FILE_TYPE_FILE));
   VerifyAndClearChange(URL(kPath1Copy),
                        FileChange(FileChange::FILE_CHANGE_ADD_OR_UPDATE,
-                                  sync_file_system::SYNC_FILE_TYPE_DIRECTORY));
+                                  SYNC_FILE_TYPE_DIRECTORY));
   VerifyAndClearChange(URL(kPath2Copy),
                        FileChange(FileChange::FILE_CHANGE_ADD_OR_UPDATE,
-                                  sync_file_system::SYNC_FILE_TYPE_DIRECTORY));
+                                  SYNC_FILE_TYPE_DIRECTORY));
   VerifyAndClearChange(URL(kPath3Copy),
                        FileChange(FileChange::FILE_CHANGE_ADD_OR_UPDATE,
-                                  sync_file_system::SYNC_FILE_TYPE_FILE));
+                                  SYNC_FILE_TYPE_FILE));
   VerifyAndClearChange(URL(kPath4Copy),
                        FileChange(FileChange::FILE_CHANGE_ADD_OR_UPDATE,
-                                  sync_file_system::SYNC_FILE_TYPE_FILE));
+                                  SYNC_FILE_TYPE_FILE));
 }
 
 TEST_F(LocalFileChangeTrackerTest, RestoreMoveChanges) {
   EXPECT_EQ(base::File::FILE_OK, file_system_.OpenFileSystem());
 
   FileSystemURLSet urls;
 
   const char kPath0[] = "file a";
   const char kPath1[] = "dir a";
   const char kPath2[] = "dir a/file";
@@ skipping 52 matching lines @@
   RestoreChangesFromTrackerDB();
 
   // Make sure the changes are restored from the DB.
   file_system_.GetChangedURLsInTracker(&urls);
   // Deletion for child files in the deleted directory cannot be restored,
   // so we will only have 8 changes.
   EXPECT_EQ(10U, urls.size());
 
   VerifyAndClearChange(URL(kPath0),
                        FileChange(FileChange::FILE_CHANGE_DELETE,
-                                  sync_file_system::SYNC_FILE_TYPE_UNKNOWN));
+                                  SYNC_FILE_TYPE_UNKNOWN));
   VerifyAndClearChange(URL(kPath1),
                        FileChange(FileChange::FILE_CHANGE_DELETE,
-                                  sync_file_system::SYNC_FILE_TYPE_UNKNOWN));
+                                  SYNC_FILE_TYPE_UNKNOWN));
   VerifyAndClearChange(URL(kPath3),
                        FileChange(FileChange::FILE_CHANGE_DELETE,
-                                  sync_file_system::SYNC_FILE_TYPE_UNKNOWN));
+                                  SYNC_FILE_TYPE_UNKNOWN));
   VerifyAndClearChange(URL(kPath5),
                        FileChange(FileChange::FILE_CHANGE_ADD_OR_UPDATE,
-                                  sync_file_system::SYNC_FILE_TYPE_FILE));
+                                  SYNC_FILE_TYPE_FILE));
   VerifyAndClearChange(URL(kPath6),
                        FileChange(FileChange::FILE_CHANGE_ADD_OR_UPDATE,
-                                  sync_file_system::SYNC_FILE_TYPE_DIRECTORY));
+                                  SYNC_FILE_TYPE_DIRECTORY));
   VerifyAndClearChange(URL(kPath7),
                        FileChange(FileChange::FILE_CHANGE_ADD_OR_UPDATE,
-                                  sync_file_system::SYNC_FILE_TYPE_FILE));
+                                  SYNC_FILE_TYPE_FILE));
   VerifyAndClearChange(URL(kPath8),
                        FileChange(FileChange::FILE_CHANGE_ADD_OR_UPDATE,
-                                  sync_file_system::SYNC_FILE_TYPE_DIRECTORY));
+                                  SYNC_FILE_TYPE_DIRECTORY));
   VerifyAndClearChange(URL(kPath9),
                        FileChange(FileChange::FILE_CHANGE_ADD_OR_UPDATE,
-                                  sync_file_system::SYNC_FILE_TYPE_FILE));
+                                  SYNC_FILE_TYPE_FILE));
 }
 
 TEST_F(LocalFileChangeTrackerTest, NextChangedURLsWithRecursiveCopy) {
   EXPECT_EQ(base::File::FILE_OK, file_system_.OpenFileSystem());
 
   FileSystemURLSet urls;
 
   const char kPath0[] = "dir a";
   const char kPath1[] = "dir a/file";
   const char kPath2[] = "dir a/dir";
@@ skipping 101 matching lines @@
 
   // Make sure they're gone from the database too.
   DropChangesInTracker();
   RestoreChangesFromTrackerDB();
 
   GetAllChangedURLs(&urls);
   EXPECT_TRUE(urls.empty());
 }
 
 }  // namespace sync_file_system