Chromium Code Reviews| Index: appengine/findit/templates/build_failure.html |
| diff --git a/appengine/findit/templates/build_failure.html b/appengine/findit/templates/build_failure.html |
| index aa6bc0438d5d664ecb8caa0905934461a2e4e77a..916f272a78b431ca3d4ae810cdd826a0a8fe7441 100644 |
| --- a/appengine/findit/templates/build_failure.html |
| +++ b/appengine/findit/templates/build_failure.html |
| @@ -334,14 +334,20 @@ |
| var rowspan = result.heuristic_analysis.suspected_cls.length > 0 ? result.heuristic_analysis.suspected_cls.length : 1; |
| tableString += generateCommonCellsForAllCategories(step_name, 'undetermined', index, result.tests, result.first_failure, result.last_pass, rowspan); |
| - tableString += '<td rowspan="' + rowspan + '">' + findit.tryjobStatusMessageMap[result.try_job.status] + '</td>'; |
| - |
| + if (findit.showDebugInfo) { |
| + tableString += '<td rowspan="' + rowspan + '">' + findit.tryjobStatusMessageMap[result.try_job.status] + '</td>'; |
|
stgao
2016/07/09 01:45:32
How about hiding just like what we do for the th h
|
| + } |
| tableString += generateHeuristicCulpritCls(result.heuristic_analysis.suspected_cls, result.supported); |
| tableString += '</tr>'; |
| }); |
| $('#unclassified_failures_table tbody').append(tableString); |
| $('#unclassified_failures').removeClass('not-display'); |
| + |
| + // Do not display Reason to non-admin users. |
| + if (! findit.showDebugInfo) { |
| + $('#unclassified_reason_th').addClass('not-display'); |
| + } |
| } |
| } |
| @@ -591,7 +597,7 @@ |
| <th rowspan="3" title="Failed test name" width="300px">Test(s)</th> |
| <th rowspan="3" title="The build cycle in which the step started to fail">First Failure</th> |
| <th rowspan="3" title="The last build cycle in which the step passed">Last Pass<br>Before Failure</th> |
| - <th rowspan="3" title="The reason we're not sure about the result">Reason</th> |
| + <th id="unclassified_reason_th" rowspan="3" title="The reason we're not sure about the result">Reason</th> |
| <th colspan="4">Suspected CLs</th> |
| </tr> |
| <tr> |