Set ShelfAlignment on supervised user creation page to BOTTOM_LOCKED

Set ShelfAlignment on supervised user creation page to BOTTOM_LOCKED

(1) first revert the hide solution in https://codereview.chromium.org/1623603002

(2) on supervised user creation page, set shelf alignment to BOTTOM_LOCKED.

BUG=606264
TEST=on supervised user creation page, shelf is no longer hidden, but set to bottom aligned. The user alignment pref is maintained after login (that is to say, left is still left).

Committed: https://crrev.com/8d5ca54363346df10c557d96215cd228b1a93c45
Cr-Commit-Position: refs/heads/master@{#404418}

[Qiang(Joe) Xu, 2016-07-07 23:22:48]

Description was changed from

==========
Set ShelfAlignment on supervised user creation page to BOTTOM_LOCKED

BUG=606264
==========

to

==========
Set ShelfAlignment on supervised user creation page to BOTTOM_LOCKED

(1) first revert the hide solution in https://codereview.chromium.org/1623603002

(2) on supervised user creation page, set shelf alignment to BOTTOM_LOCKED.

BUG=606264
==========

[Qiang(Joe) Xu, 2016-07-07 23:22:48]

warx@chromium.org changed reviewers:
+ dzhioev@chromium.org, jdufault@chromium.org

[Qiang(Joe) Xu, 2016-07-07 23:24:14]

Description was changed from

==========
Set ShelfAlignment on supervised user creation page to BOTTOM_LOCKED

(1) first revert the hide solution in https://codereview.chromium.org/1623603002

(2) on supervised user creation page, set shelf alignment to BOTTOM_LOCKED.

BUG=606264
==========

to

==========
Set ShelfAlignment on supervised user creation page to BOTTOM_LOCKED

(1) first revert the hide solution in https://codereview.chromium.org/1623603002

(2) on supervised user creation page, set shelf alignment to BOTTOM_LOCKED.

BUG=606264
TEST=on supervised user creation page, shelf is no longer hidden, but set to
bottom aligned. The user alignment pref is maintained after login (that is to
say, left is still left).
==========

[Qiang(Joe) Xu, 2016-07-07 23:24:57]

+dzhioev for owner review
+jdufault for reverting your cl contents

thanks!

[jdufault, 2016-07-07 23:26:51]

lgtm

https://codereview.chromium.org/2129013002/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/ui/webui_login_view.cc (right):

https://codereview.chromium.org/2129013002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/ui/webui_login_view.cc:323:
tray->GetWidget()->SetOpacity(visible ? 1.0 : 0.0);
I don't think this change should get reverted.

[Qiang(Joe) Xu, 2016-07-08 00:18:41]

https://codereview.chromium.org/2129013002/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/ui/webui_login_view.cc (right):

https://codereview.chromium.org/2129013002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/ui/webui_login_view.cc:323:
tray->GetWidget()->SetOpacity(visible ? 1.0 : 0.0);
On 2016/07/07 23:26:50, jdufault wrote:
> I don't think this change should get reverted.

done. tks.

[Qiang(Joe) Xu, 2016-07-08 06:07:03]

warx@chromium.org changed reviewers:
+ alemate@chromium.org

[Qiang(Joe) Xu, 2016-07-08 06:08:13]

+@alemate for owner review since @dzhioev is OOO until 7/18, thanks!

[Alexander Alekseev, 2016-07-08 07:17:41]

lgtm

[Qiang(Joe) Xu, 2016-07-08 16:05:54]

The CQ bit was checked by warx@chromium.org

[Qiang(Joe) Xu, 2016-07-08 16:05:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
jdufault@chromium.org
Link to the patchset: https://codereview.chromium.org/2129013002/#ps20001
(title: "nit")

[commit-bot: I haz the power, 2016-07-08 16:06:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 16:58:36]

Description was changed from

==========
Set ShelfAlignment on supervised user creation page to BOTTOM_LOCKED

(1) first revert the hide solution in https://codereview.chromium.org/1623603002

(2) on supervised user creation page, set shelf alignment to BOTTOM_LOCKED.

BUG=606264
TEST=on supervised user creation page, shelf is no longer hidden, but set to
bottom aligned. The user alignment pref is maintained after login (that is to
say, left is still left).
==========

to

==========
Set ShelfAlignment on supervised user creation page to BOTTOM_LOCKED

(1) first revert the hide solution in https://codereview.chromium.org/1623603002

(2) on supervised user creation page, set shelf alignment to BOTTOM_LOCKED.

BUG=606264
TEST=on supervised user creation page, shelf is no longer hidden, but set to
bottom aligned. The user alignment pref is maintained after login (that is to
say, left is still left).
==========

[commit-bot: I haz the power, 2016-07-08 16:58:37]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-08 16:58:49]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-08 17:01:15]

Description was changed from

==========
Set ShelfAlignment on supervised user creation page to BOTTOM_LOCKED

(1) first revert the hide solution in https://codereview.chromium.org/1623603002

(2) on supervised user creation page, set shelf alignment to BOTTOM_LOCKED.

BUG=606264
TEST=on supervised user creation page, shelf is no longer hidden, but set to
bottom aligned. The user alignment pref is maintained after login (that is to
say, left is still left).
==========

to

==========
Set ShelfAlignment on supervised user creation page to BOTTOM_LOCKED

(1) first revert the hide solution in https://codereview.chromium.org/1623603002

(2) on supervised user creation page, set shelf alignment to BOTTOM_LOCKED.

BUG=606264
TEST=on supervised user creation page, shelf is no longer hidden, but set to
bottom aligned. The user alignment pref is maintained after login (that is to
say, left is still left).

Committed: https://crrev.com/8d5ca54363346df10c557d96215cd228b1a93c45
Cr-Commit-Position: refs/heads/master@{#404418}
==========

[commit-bot: I haz the power, 2016-07-08 17:01:16]

Patchset 2 (id:??) landed as
https://crrev.com/8d5ca54363346df10c557d96215cd228b1a93c45
Cr-Commit-Position: refs/heads/master@{#404418}