Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 1623603002: When adding a supervised user, ensure the shelf position is at the bottom. (Closed)

Created:
4 years, 11 months ago by jdufault
Modified:
4 years, 11 months ago
CC:
chromium-reviews, pam+watch_chromium.org, dzhioev+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@move-login-display-host
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

When adding a supervised user, ensure the shelf position is at the bottom. BUG=532545 Committed: https://crrev.com/c82e242afa605bb22f99cfcaca6e0aa916a1bc24 Cr-Commit-Position: refs/heads/master@{#371358}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/ui/webui_login_view.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (7 generated)
jdufault
Achuith / Pavel PTAL. This change has just been split off from the parent into ...
4 years, 11 months ago (2016-01-22 21:15:59 UTC) #3
achuithb
Thank you, LGTM
4 years, 11 months ago (2016-01-22 22:24:18 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1623603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1623603002/1
4 years, 11 months ago (2016-01-22 22:25:07 UTC) #6
dzhioev (left Google)
On 2016/01/22 21:15:59, jdufault wrote: > Achuith / Pavel PTAL. This change has just been ...
4 years, 11 months ago (2016-01-22 22:41:30 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-22 23:41:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1623603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1623603002/1
4 years, 11 months ago (2016-01-25 22:57:49 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-26 00:02:18 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 00:04:57 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c82e242afa605bb22f99cfcaca6e0aa916a1bc24
Cr-Commit-Position: refs/heads/master@{#371358}

Powered by Google App Engine
This is Rietveld 408576698