Enable NonValidatingReloadOnNormalReload on variations testing

Enable NonValidatingReloadOnNormalReload on variations testing

To expand the field study to Beta channel, enable the feature
on variations testing waterfall.

BUG=612701
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/7ae0fd5c2969a7253c23fdad6993898323aba694
Cr-Commit-Position: refs/heads/master@{#404321}

[Takashi Toyoshima, 2016-07-07 07:17:06]

Description was changed from

==========
Enable NonValidatingReloadOnNormalReload on variations testing

To expand the field study to Beta channel, enable the feature
on variations testing waterfall.

BUG=612701
==========

to

==========
Enable NonValidatingReloadOnNormalReload on variations testing

To expand the field study to Beta channel, enable the feature
on variations testing waterfall.

BUG=612701
==========

[Takashi Toyoshima, 2016-07-07 07:17:06]

toyoshim@chromium.org changed reviewers:
+ isherman@chromium.org

[Takashi Toyoshima, 2016-07-07 08:50:15]

Description was changed from

==========
Enable NonValidatingReloadOnNormalReload on variations testing

To expand the field study to Beta channel, enable the feature
on variations testing waterfall.

BUG=612701
==========

to

==========
Enable NonValidatingReloadOnNormalReload on variations testing

To expand the field study to Beta channel, enable the feature
on variations testing waterfall.

BUG=612701
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[Takashi Toyoshima, 2016-07-07 08:51:11]

One bug was found, and fix was split to
https://codereview.chromium.org/2124253002/

[Takashi Toyoshima, 2016-07-07 10:42:35]

The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-07 10:42:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Takashi Toyoshima, 2016-07-07 10:42:55]

Description was changed from

==========
Enable NonValidatingReloadOnNormalReload on variations testing

To expand the field study to Beta channel, enable the feature
on variations testing waterfall.

BUG=612701
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Enable NonValidatingReloadOnNormalReload on variations testing

To expand the field study to Beta channel, enable the feature
on variations testing waterfall.

BUG=612701
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[Takashi Toyoshima, 2016-07-07 10:42:55]

toyoshim@chromium.org changed reviewers:
+ kinuko@chromium.org

[Takashi Toyoshima, 2016-07-07 10:45:14]

BrowserTest.BeforeUnloadVsBeforeReload will fail in the dry run, and the CL
https://codereview.chromium.org/2124253002/ in CQ fixes this issue.

Kinuko: can you take a look on content/ ?
Ilyta: can you take a look on testing/ ?

[commit-bot: I haz the power, 2016-07-07 11:19:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-07 11:19:20]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ilya Sherman, 2016-07-07 20:02:18]

testing configs lgtm

[kinuko, 2016-07-08 04:33:51]

lgtm % nits

https://codereview.chromium.org/2128783002/diff/20001/content/browser/frame_h...
File content/browser/frame_host/navigator_impl_unittest.cc (right):

https://codereview.chromium.org/2128783002/diff/20001/content/browser/frame_h...
content/browser/frame_host/navigator_impl_unittest.cc:837: // TODO(toyoshim):
Motified following checks once the feature is enabled.
Motified -> Modify ?

https://codereview.chromium.org/2128783002/diff/20001/content/browser/loader/...
File content/browser/loader/reload_cache_control_browsertest.cc (right):

https://codereview.chromium.org/2128783002/diff/20001/content/browser/loader/...
content/browser/loader/reload_cache_control_browsertest.cc:57: void
FinishToSetUpOnMainThread() {
I think it'd be better to give a clearer/straightforward name to this one?  E.g.
SetUpTestServerOnMainThread()

[Takashi Toyoshima, 2016-07-08 06:34:27]

https://codereview.chromium.org/2128783002/diff/20001/content/browser/frame_h...
File content/browser/frame_host/navigator_impl_unittest.cc (right):

https://codereview.chromium.org/2128783002/diff/20001/content/browser/frame_h...
content/browser/frame_host/navigator_impl_unittest.cc:837: // TODO(toyoshim):
Motified following checks once the feature is enabled.
On 2016/07/08 04:33:50, kinuko wrote:
> Motified -> Modify ?

Done.

https://codereview.chromium.org/2128783002/diff/20001/content/browser/loader/...
File content/browser/loader/reload_cache_control_browsertest.cc (right):

https://codereview.chromium.org/2128783002/diff/20001/content/browser/loader/...
content/browser/loader/reload_cache_control_browsertest.cc:57: void
FinishToSetUpOnMainThread() {
On 2016/07/08 04:33:50, kinuko wrote:
> I think it'd be better to give a clearer/straightforward name to this one? 
E.g.
> SetUpTestServerOnMainThread()

Done.

[Takashi Toyoshima, 2016-07-08 06:34:33]

The CQ bit was checked by toyoshim@chromium.org

[Takashi Toyoshima, 2016-07-08 06:34:34]

The patchset sent to the CQ was uploaded after l-g-t-m from kinuko@chromium.org,
isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/2128783002/#ps40001
(title: "done")

[commit-bot: I haz the power, 2016-07-08 06:35:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 07:24:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-08 07:24:13]

Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_site_isolation on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_site_isol...)

[Takashi Toyoshima, 2016-07-08 08:04:22]

The CQ bit was checked by toyoshim@chromium.org

[commit-bot: I haz the power, 2016-07-08 08:05:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 09:30:06]

Description was changed from

==========
Enable NonValidatingReloadOnNormalReload on variations testing

To expand the field study to Beta channel, enable the feature
on variations testing waterfall.

BUG=612701
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Enable NonValidatingReloadOnNormalReload on variations testing

To expand the field study to Beta channel, enable the feature
on variations testing waterfall.

BUG=612701
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-07-08 09:30:07]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-08 09:32:26]

Description was changed from

==========
Enable NonValidatingReloadOnNormalReload on variations testing

To expand the field study to Beta channel, enable the feature
on variations testing waterfall.

BUG=612701
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Enable NonValidatingReloadOnNormalReload on variations testing

To expand the field study to Beta channel, enable the feature
on variations testing waterfall.

BUG=612701
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/7ae0fd5c2969a7253c23fdad6993898323aba694
Cr-Commit-Position: refs/heads/master@{#404321}
==========

[commit-bot: I haz the power, 2016-07-08 09:32:28]

Patchset 3 (id:??) landed as
https://crrev.com/7ae0fd5c2969a7253c23fdad6993898323aba694
Cr-Commit-Position: refs/heads/master@{#404321}