Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Unified Diff: content/browser/frame_host/navigator_impl_unittest.cc

Issue 2128783002: Enable NonValidatingReloadOnNormalReload on variations testing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: done Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/loader/reload_cache_control_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/navigator_impl_unittest.cc
diff --git a/content/browser/frame_host/navigator_impl_unittest.cc b/content/browser/frame_host/navigator_impl_unittest.cc
index d869f06a0d13c5d27c397fcbd5c5a5f55356297f..6b8bc12df990c10d3e113fb3da84cba137871dd5 100644
--- a/content/browser/frame_host/navigator_impl_unittest.cc
+++ b/content/browser/frame_host/navigator_impl_unittest.cc
@@ -4,6 +4,7 @@
#include <stdint.h>
+#include "base/feature_list.h"
#include "base/macros.h"
#include "base/time/time.h"
#include "build/build_config.h"
@@ -21,6 +22,7 @@
#include "content/common/site_isolation_policy.h"
#include "content/public/browser/navigation_data.h"
#include "content/public/browser/stream_handle.h"
+#include "content/public/common/content_features.h"
#include "content/public/common/url_constants.h"
#include "content/public/common/url_utils.h"
#include "content/public/test/mock_render_process_host.h"
@@ -832,8 +834,15 @@ TEST_F(NavigatorTestWithBrowserSideNavigation, Reload) {
// A NavigationRequest should have been generated.
NavigationRequest* main_request = node->navigation_request();
ASSERT_TRUE(main_request != NULL);
- EXPECT_EQ(FrameMsg_Navigate_Type::RELOAD,
- main_request->common_params().navigation_type);
+ // TODO(toyoshim): Modify following checks once the feature is enabled.
+ if (base::FeatureList::IsEnabled(
+ features::kNonValidatingReloadOnNormalReload)) {
+ EXPECT_EQ(FrameMsg_Navigate_Type::RELOAD_MAIN_RESOURCE,
+ main_request->common_params().navigation_type);
+ } else {
+ EXPECT_EQ(FrameMsg_Navigate_Type::RELOAD,
+ main_request->common_params().navigation_type);
+ }
main_test_rfh()->PrepareForCommit();
EXPECT_FALSE(GetSpeculativeRenderFrameHost(node));
« no previous file with comments | « no previous file | content/browser/loader/reload_cache_control_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698