Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1134)

Issue 2128643002: Fixed instruction corruption bug for multiple returns. (Closed)

Created:
4 years, 5 months ago by tlively
Modified:
4 years, 5 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fixed instruction corruption bug for multiple returns. BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4374 R=kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=a7e5a951381aeb5390c460b810cd2b01e888ee4a

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -8 lines) Patch
M pydir/szbuild.py View 2 chunks +6 lines, -5 lines 1 comment Download
M src/IceASanInstrumentation.cpp View 3 chunks +12 lines, -3 lines 1 comment Download
A tests_lit/asan_tests/multiple_returns.ll View 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
tlively
https://codereview.chromium.org/2128643002/diff/1/pydir/szbuild.py File pydir/szbuild.py (right): https://codereview.chromium.org/2128643002/diff/1/pydir/szbuild.py#newcode310 pydir/szbuild.py:310: args.sz_args.append('-fsanitize-address') This redundancy check is necessary because szbuild_spec2k.py runs ...
4 years, 5 months ago (2016-07-06 19:47:05 UTC) #2
Karl
lgtm
4 years, 5 months ago (2016-07-06 20:21:33 UTC) #3
tlively
4 years, 5 months ago (2016-07-06 20:46:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a7e5a951381aeb5390c460b810cd2b01e888ee4a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698