Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(914)

Unified Diff: pydir/szbuild.py

Issue 2128643002: Fixed instruction corruption bug for multiple returns. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/IceASanInstrumentation.cpp » ('j') | src/IceASanInstrumentation.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pydir/szbuild.py
diff --git a/pydir/szbuild.py b/pydir/szbuild.py
index 73337294c607e3592db39035851ceff9437dfb2a..3e1722bbfe5dba4a68fc66c09aabe1ee9b022fb1 100755
--- a/pydir/szbuild.py
+++ b/pydir/szbuild.py
@@ -266,11 +266,6 @@ def main():
args = argparser.parse_args()
pexe = args.pexe
exe = args.output
- if args.asan:
- if args.sandbox or args.nonsfi:
- print 'Can only use AddressSanitizer with a native build'
- exit(1)
- args.sz_args.append('-fsanitize-address')
ProcessPexe(args, pexe, exe)
def ProcessPexe(args, pexe, exe):
@@ -307,6 +302,12 @@ def ProcessPexe(args, pexe, exe):
opt_level_map = { 'm1':'0', '-1':'0', '0':'0', '1':'1', '2':'2' }
hybrid = args.include or args.exclude
native = not args.sandbox and not args.nonsfi
+ if args.asan:
+ if args.sandbox or args.nonsfi:
+ print 'Can only use AddressSanitizer with a native build'
+ exit(1)
+ if '-fsanitize-address' not in args.sz_args:
+ args.sz_args.append('-fsanitize-address')
tlively 2016/07/06 19:47:05 This redundancy check is necessary because szbuild
if hybrid and (args.force or
NewerThanOrNotThere(pexe, obj_llc) or
« no previous file with comments | « no previous file | src/IceASanInstrumentation.cpp » ('j') | src/IceASanInstrumentation.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698