Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1904)

Unified Diff: scripts/slave/recipe_modules/chromium_tests/chromium_perf.py

Issue 2128613005: Archive Linux perf builds for manual bisect (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: added a missing comma Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/chromium_tests/chromium_perf.py
diff --git a/scripts/slave/recipe_modules/chromium_tests/chromium_perf.py b/scripts/slave/recipe_modules/chromium_tests/chromium_perf.py
index af71431a79166f1bd78e588b3ccda9dbecbd6593..286265d1d1cb35e47093a5ac7fb8d2fa2897147f 100644
--- a/scripts/slave/recipe_modules/chromium_tests/chromium_perf.py
+++ b/scripts/slave/recipe_modules/chromium_tests/chromium_perf.py
@@ -14,6 +14,10 @@ SPEC = {
'builders': {},
'settings': {
'build_gs_bucket': 'chrome-perf',
+ # Bucket for storing builds for manual bisect
+ 'bisect_build_gs_bucket': 'chrome-test-builds',
+ 'bisect_build_gs_extra': 'official-by-commit',
+ 'bisect_builders': []
},
}
@@ -93,7 +97,7 @@ def _TestSpec(config_name, parent_builder, perf_id, platform, target_bits,
return spec
-def _AddBuildSpec(name, platform, target_bits=64):
+def _AddBuildSpec(name, platform, target_bits=64, add_to_bisect=False):
if target_bits == 64:
perf_id = platform
else:
@@ -103,6 +107,8 @@ def _AddBuildSpec(name, platform, target_bits=64):
'chromium_perf', perf_id, platform, target_bits)
assert target_bits not in _builders[platform]
_builders[platform][target_bits] = name
+ if add_to_bisect:
+ SPEC['settings']['bisect_builders'].append(name)
def _AddTestSpec(name, perf_id, platform, target_bits=64,
@@ -120,7 +126,7 @@ _AddBuildSpec('Android arm64 Builder', 'android')
_AddBuildSpec('Win Builder', 'win', target_bits=32)
_AddBuildSpec('Win x64 Builder', 'win')
_AddBuildSpec('Mac Builder', 'mac')
-_AddBuildSpec('Linux Builder', 'linux')
+_AddBuildSpec('Linux Builder', 'linux', add_to_bisect=True)
_AddTestSpec('Android Galaxy S5 Perf', 'android-galaxy-s5', 'android',

Powered by Google App Engine
This is Rietveld 408576698