Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Unified Diff: scripts/slave/recipe_modules/chromium_tests/api.py

Issue 2128613005: Archive Linux perf builds for manual bisect (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: added a missing comma Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/chromium_tests/api.py
diff --git a/scripts/slave/recipe_modules/chromium_tests/api.py b/scripts/slave/recipe_modules/chromium_tests/api.py
index a9dcf6da9f3d5053598af49eb6a2cec7ba0f28da..d40e13c77be12dde3f4df8cf767ac7311f8d2fa4 100644
--- a/scripts/slave/recipe_modules/chromium_tests/api.py
+++ b/scripts/slave/recipe_modules/chromium_tests/api.py
@@ -404,6 +404,23 @@ class ChromiumTestsApi(recipe_api.RecipeApi):
if not bot_config.get('cf_archive_build'):
master_config = bot_db.get_master_settings(mastername)
build_revision = update_step.presentation.properties['got_revision']
+
+ # For archiving 'chromium.perf', the builder also archives a version
+ # without perf test files for manual bisect.
+ # (https://bugs.chromium.org/p/chromium/issues/detail?id=604452)
+ if (master_config.get('bisect_builders') and
+ buildername in master_config.get('bisect_builders')):
+ self.m.archive.zip_and_upload_build(
+ 'package build for bisect',
+ self.m.chromium.c.build_config_fs,
+ build_url=self._build_bisect_gs_archive_url(master_config),
+ build_revision=build_revision,
+ cros_board=self.m.chromium.c.TARGET_CROS_BOARD,
+ update_properties=update_step.presentation.properties,
+ exclude_perf_test_files=True,
+ store_by_hash=False
+ )
+
self.m.archive.zip_and_upload_build(
'package build',
self.m.chromium.c.build_config_fs,
@@ -678,6 +695,11 @@ class ChromiumTestsApi(recipe_api.RecipeApi):
return self.m.chromium_swarming.configure_swarming( # pragma: no cover
project_name, precommit, mastername)
+ def _build_bisect_gs_archive_url(self, master_config):
+ return self.m.archive.legacy_upload_url(
+ master_config.get('bisect_build_gs_bucket'),
+ extra_url_components=master_config.get('bisect_build_gs_extra'))
+
def _build_gs_archive_url(self, mastername, master_config, buildername):
"""Returns the archive URL to pass to self.m.archive.zip_and_upload_build.

Powered by Google App Engine
This is Rietveld 408576698