Archive Linux perf builds for manual bisect

scripts/slave/recipe_modules/archive/api.py

Index: scripts/slave/recipe_modules/archive/api.py
diff --git a/scripts/slave/recipe_modules/archive/api.py b/scripts/slave/recipe_modules/archive/api.py
index 10cddd8a5aed76335a1bf2f882a33ebc0559866c..408e2015c292b616f3afaaae87edcfcec9d6cd54 100644
--- a/scripts/slave/recipe_modules/archive/api.py
+++ b/scripts/slave/recipe_modules/archive/api.py
@@ -5,6 +5,7 @@
 import re
 
 from recipe_engine import recipe_api
+from . import perf_test_files
 
 
 # TODO(machenbach): Chromium specific data should move out of the archive
@@ -116,6 +117,20 @@ class ArchiveApi(recipe_api.RecipeApi):
       args.extend(['--exclude-files', exclude_files])
     if 'gs_acl' in self.m.properties:
       args.extend(['--gs-acl', self.m.properties['gs_acl']])
+    if not kwargs.pop("includePerfTestFiles", True):

[dtu, 2016/08/05 21:06:18]

style nit: argument/variable names are always lowercase_with_underscores.

style nit: I think we generally use single quotes for string literals

It looks like kwargs is being used in this function for arguments to be
forwarded onto self.m.python(). Since you're using include_perf_test_files in
this function, you should declare it in the function definition.

[miimnk, 2016/08/08 22:41:23]

Fixed the variable name with lowercase_with_underscores.
Passed include_perf_test_files, update_properties, store_by_hash as parameters
instead of passing through **kwargs. Did you mean to only pass
include_perf_test_files as a parameter? 

+      inclusions = ','.join(perf_test_files.CHROME_REQUIRED_FILES)
+      strip_files = ','.join(perf_test_files.CHROME_STRIP_LIST)
+      args.extend(['--include-files', inclusions])
+      args.extend(['--ignore_regex'])
+      args.extend(['--strip_files', strip_files])
+      # If update_properties is passed in and store_by_hash is False,
+      # we store it with commit position number instead of a hash
+      update_properties = kwargs.pop("update_properties", None)
+      if update_properties and not kwargs.pop("store_by_hash", True):
+        commit_position = self._get_commit_position(
+                            update_properties, None)
+        cp_branch, cp_number = self.m.commit_position.parse(commit_position)
+        args.extend(['--build_revision', cp_number])
 
     properties_json = self.m.json.dumps(self.m.properties.legacy())
     args.extend(['--factory-properties', properties_json,