Archive Linux perf builds for manual bisect

scripts/slave/recipe_modules/archive/api.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import re
 
 from recipe_engine import recipe_api
+from . import perf_test_files
 
 
 # TODO(machenbach): Chromium specific data should move out of the archive
 # module, into e.g. the chromium test configs.
 EXCLUDED_FILES_ALL_PLATFORMS = [
   '.landmines',
   '.ninja_deps',
   '.ninja_log',
   'gen',
   'obj',
@@ skipping 91 matching lines @@
     elif src_dir:
       args.extend(['--src-dir', src_dir])
     if cros_board:
       args.extend(['--cros-board', cros_board])
     if package_dsym_files:
       args.append('--package-dsym-files')
     if exclude_files:
       args.extend(['--exclude-files', exclude_files])
     if 'gs_acl' in self.m.properties:
       args.extend(['--gs-acl', self.m.properties['gs_acl']])
+    if not kwargs.pop("includePerfTestFiles", True):

[dtu, 2016/08/05 21:06:18]

style nit: argument/variable names are always lowercase_with_underscores.

style nit: I think we generally use single quotes for string literals

It looks like kwargs is being used in this function for arguments to be
forwarded onto self.m.python(). Since you're using include_perf_test_files in
this function, you should declare it in the function definition.

[miimnk, 2016/08/08 22:41:23]

Fixed the variable name with lowercase_with_underscores.
Passed include_perf_test_files, update_properties, store_by_hash as parameters
instead of passing through **kwargs. Did you mean to only pass
include_perf_test_files as a parameter? 

+      inclusions = ','.join(perf_test_files.CHROME_REQUIRED_FILES)
+      strip_files = ','.join(perf_test_files.CHROME_STRIP_LIST)
+      args.extend(['--include-files', inclusions])
+      args.extend(['--ignore_regex'])
+      args.extend(['--strip_files', strip_files])
+      # If update_properties is passed in and store_by_hash is False,
+      # we store it with commit position number instead of a hash
+      update_properties = kwargs.pop("update_properties", None)
+      if update_properties and not kwargs.pop("store_by_hash", True):
+        commit_position = self._get_commit_position(
+                            update_properties, None)
+        cp_branch, cp_number = self.m.commit_position.parse(commit_position)
+        args.extend(['--build_revision', cp_number])
 
     properties_json = self.m.json.dumps(self.m.properties.legacy())
     args.extend(['--factory-properties', properties_json,
                  '--build-properties', properties_json])
 
     kwargs['allow_subannotations'] = True
     self.m.python(
       step_name,
       self.package_repo_resource('scripts', 'tools', 'runit.py'),
       args,
@@ skipping 273 matching lines @@
   def legacy_download_url(self, gs_bucket_name, extra_url_components=None):
     """Returns a url suitable for downloading a Chromium build from
     Google Storage.
 
     extra_url_components, if specified, should be a string without a
     trailing '/' which is inserted in the middle of the URL.
 
     The builder_name, or parent_buildername, is always automatically
     inserted into the URL."""
     return self._legacy_url(True, gs_bucket_name, extra_url_components)