Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2128613002: Fix date picker datalist suggestion dropdown size with use-zoom-for-dsf. (Closed)

Created:
4 years, 5 months ago by Bret
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Fix date picker datalist suggestion dropdown size with use-zoom-for-dsf. When a date picker has a suggestion list it's supposed to be the same width as the input element. With use-zoom-for-dsf on I discovered that it was too wide because the width that was being passed in was using "root frame" coords that were not scaled correctly. BUG=621221 Review-Url: https://codereview.chromium.org/2095113002 Cr-Commit-Position: refs/heads/master@{#403394} (cherry picked from commit 0e94f26e8f22e96fda6ade9ccb35380906ee77ab) Committed: https://chromium.googlesource.com/chromium/src/+/2d0823f5455d1a2918b764006a7dad26106bfc5e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLInputElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLInputElementTest.cpp View 2 chunks +20 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/DateTimeChooser.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/DateTimeChooserImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Bret
4 years, 5 months ago (2016-07-06 18:09:58 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2d0823f5455d1a2918b764006a7dad26106bfc5e.

Powered by Google App Engine
This is Rietveld 408576698