Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 2095113002: Fix date picker datalist suggestion dropdown size with use-zoom-for-dsf. (Closed)

Created:
4 years, 6 months ago by Bret
Modified:
4 years, 5 months ago
CC:
blink-reviews, chromium-reviews, kinuko+watch, oshima
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix date picker datalist suggestion dropdown size with use-zoom-for-dsf. When a date picker has a suggestion list it's supposed to be the same width as the input element. With use-zoom-for-dsf on I discovered that it was too wide because the width that was being passed in was using "root frame" coords that were not scaled correctly. BUG=621221 Committed: https://crrev.com/0e94f26e8f22e96fda6ade9ccb35380906ee77ab Cr-Commit-Position: refs/heads/master@{#403394}

Patch Set 1 #

Patch Set 2 : add test #

Patch Set 3 : fix tests #

Patch Set 4 : forgot to rebaseline linux #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLInputElement.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLInputElementTest.cpp View 1 2 2 chunks +20 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/DateTimeChooser.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/DateTimeChooserImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 34 (17 generated)
Bret
4 years, 6 months ago (2016-06-24 19:12:44 UTC) #4
aelias_OOO_until_Jul13
Could you write a unit test?
4 years, 6 months ago (2016-06-24 21:48:07 UTC) #5
Bret
Added a unit test for setting the correct input element size when initializing the date/time ...
4 years, 5 months ago (2016-06-28 23:08:23 UTC) #7
keishi
LGTM
4 years, 5 months ago (2016-06-29 01:18:51 UTC) #8
aelias_OOO_until_Jul13
lgtm
4 years, 5 months ago (2016-06-29 07:22:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2095113002/20001
4 years, 5 months ago (2016-06-29 17:05:06 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/252433)
4 years, 5 months ago (2016-06-29 17:54:56 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2095113002/40001
4 years, 5 months ago (2016-06-30 02:01:32 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/255295)
4 years, 5 months ago (2016-06-30 03:20:16 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2095113002/60001
4 years, 5 months ago (2016-06-30 17:13:57 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/248581)
4 years, 5 months ago (2016-06-30 17:52:40 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2095113002/60001
4 years, 5 months ago (2016-06-30 18:59:34 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/255798)
4 years, 5 months ago (2016-06-30 21:14:33 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2095113002/60001
4 years, 5 months ago (2016-06-30 23:58:42 UTC) #29
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-01 02:37:00 UTC) #31
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-01 02:37:02 UTC) #32
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 02:39:31 UTC) #34
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/0e94f26e8f22e96fda6ade9ccb35380906ee77ab
Cr-Commit-Position: refs/heads/master@{#403394}

Powered by Google App Engine
This is Rietveld 408576698