Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 2128593003: Measure usage of MediaStream.prototype.active (Closed)

Created:
4 years, 5 months ago by foolip
Modified:
4 years, 5 months ago
CC:
chromium-reviews, blink-reviews, haraken, tommyw+watchlist_chromium.org, asvitkine+watch_chromium.org, mcasas+watch+mediastream_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Measure usage of MediaStream.prototype.active The active/inactive events have been removed from the spec, but the active attribute has not, so removing just the events wouldn't reduce complexity by much. Gecko doesn't have the attribute either, so measure its usage before deciding on the next steps. Related spec issue: https://github.com/w3c/mediacapture-main/issues/370 R=guidou@chromium.org,isherman@chromium.org Committed: https://crrev.com/851f0291106fd0d444553c079e3004b815b8f957 Cr-Commit-Position: refs/heads/master@{#404352}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStream.idl View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
foolip
4 years, 5 months ago (2016-07-07 09:14:17 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2128593003/1
4 years, 5 months ago (2016-07-07 09:14:45 UTC) #3
Guido Urdaneta
lgtm
4 years, 5 months ago (2016-07-07 09:22:00 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-07 10:32:02 UTC) #6
Ilya Sherman
histograms.xml lgtm
4 years, 5 months ago (2016-07-07 20:01:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2128593003/1
4 years, 5 months ago (2016-07-08 07:41:43 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 14:07:53 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 14:10:41 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/851f0291106fd0d444553c079e3004b815b8f957
Cr-Commit-Position: refs/heads/master@{#404352}

Powered by Google App Engine
This is Rietveld 408576698