Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2128563002: Move scheduleAnimation calls from WebViewClient to WebWidgetClient. (Closed)

Created:
4 years, 5 months ago by lfg
Modified:
4 years, 5 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, dglazkov+blink, darin-cc_chromium.org, blink-reviews, kinuko+watch, blink-reviews-api_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move scheduleAnimation calls from WebViewClient to WebWidgetClient. This is part of a refactor to split WebView/WebWidget. BUG=419087 Committed: https://crrev.com/12136c6df9020eb8c418597887c6769b3a454111 Cr-Commit-Position: refs/heads/master@{#406580}

Patch Set 1 #

Patch Set 2 : remove virtual #

Patch Set 3 : rebase #

Total comments: 2

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -16 lines) Patch
M content/renderer/render_view_impl.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/LinkHighlightImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebPagePopupImpl.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewFrameWidget.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.h View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 2 3 5 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/public/web/WebViewClient.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 20 (10 generated)
lfg
PTAL.
4 years, 5 months ago (2016-07-15 18:42:38 UTC) #2
dcheng
LGTM
4 years, 5 months ago (2016-07-18 05:51:05 UTC) #3
lfg
+avi, please take a look.
4 years, 5 months ago (2016-07-18 15:12:41 UTC) #5
Avi (use Gerrit)
lgtm https://codereview.chromium.org/2128563002/diff/40001/third_party/WebKit/public/web/WebViewClient.h File third_party/WebKit/public/web/WebViewClient.h (right): https://codereview.chromium.org/2128563002/diff/40001/third_party/WebKit/public/web/WebViewClient.h#newcode279 third_party/WebKit/public/web/WebViewClient.h:279: WebWidgetClient* widgetClient() { return this; } Do you ...
4 years, 5 months ago (2016-07-18 15:15:58 UTC) #6
lfg
https://codereview.chromium.org/2128563002/diff/40001/third_party/WebKit/public/web/WebViewClient.h File third_party/WebKit/public/web/WebViewClient.h (right): https://codereview.chromium.org/2128563002/diff/40001/third_party/WebKit/public/web/WebViewClient.h#newcode279 third_party/WebKit/public/web/WebViewClient.h:279: WebWidgetClient* widgetClient() { return this; } On 2016/07/18 15:15:58, ...
4 years, 5 months ago (2016-07-18 15:20:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2128563002/40001
4 years, 5 months ago (2016-07-18 16:45:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2128563002/60001
4 years, 5 months ago (2016-07-20 15:30:34 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-20 16:26:00 UTC) #17
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-20 16:26:04 UTC) #18
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 16:27:21 UTC) #20
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/12136c6df9020eb8c418597887c6769b3a454111
Cr-Commit-Position: refs/heads/master@{#406580}

Powered by Google App Engine
This is Rietveld 408576698