third_party/WebKit/public/web/WebViewClient.h - Issue 2128563002: Move scheduleAnimation calls from WebViewClient to WebWidgetClient.

Side by Side Diff: third_party/WebKit/public/web/WebViewClient.h

Issue 2128563002: Move scheduleAnimation calls from WebViewClient to WebWidgetClient. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/web/WebViewImpl.cpp ('k') | no next file » | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2009 Google Inc. All rights reserved.	2 * Copyright (C) 2009 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 249 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
260 void didHandleGestureEvent(const WebGestureEvent& event, bool eventCancelled ) override {}	260 void didHandleGestureEvent(const WebGestureEvent& event, bool eventCancelled ) override {}

261 void didInvalidateRect(const WebRect&) override {}	261 void didInvalidateRect(const WebRect&) override {}

262 void didOverscroll(const WebFloatSize& overscrollDelta, const WebFloatSize& accumulatedOverscroll, const WebFloatPoint& positionInViewport, const WebFloatSi ze& velocityInViewport) override {}	262 void didOverscroll(const WebFloatSize& overscrollDelta, const WebFloatSize& accumulatedOverscroll, const WebFloatPoint& positionInViewport, const WebFloatSi ze& velocityInViewport) override {}

263 void didUpdateTextOfFocusedElementByNonUserInput() override {}	263 void didUpdateTextOfFocusedElementByNonUserInput() override {}

264 void hasTouchEventHandlers(bool) override {}	264 void hasTouchEventHandlers(bool) override {}

265 void initializeLayerTreeView() override {}	265 void initializeLayerTreeView() override {}

266 WebLayerTreeView* layerTreeView() override { return 0; }	266 WebLayerTreeView* layerTreeView() override { return 0; }

267 void onMouseDown(const WebNode& mouseDownNode) override {}	267 void onMouseDown(const WebNode& mouseDownNode) override {}

268 void resetInputMethod() override {}	268 void resetInputMethod() override {}

269 WebRect rootWindowRect() override { return WebRect(); }	269 WebRect rootWindowRect() override { return WebRect(); }

270 void scheduleAnimation() override {}

271 WebScreenInfo screenInfo() override { return WebScreenInfo(); }	270 WebScreenInfo screenInfo() override { return WebScreenInfo(); }

272 void setToolTipText(const WebString&, WebTextDirection hint) override {}	271 void setToolTipText(const WebString&, WebTextDirection hint) override {}

273 void setTouchAction(WebTouchAction touchAction) override {}	272 void setTouchAction(WebTouchAction touchAction) override {}

274 void setWindowRect(const WebRect&) override {}	273 void setWindowRect(const WebRect&) override {}

275 void showImeIfNeeded() override {}	274 void showImeIfNeeded() override {}

276 void showUnhandledTapUIIfNeeded(const WebPoint& tappedPosition, const WebNod e& tappedNode, bool pageChanged) override {}	275 void showUnhandledTapUIIfNeeded(const WebPoint& tappedPosition, const WebNod e& tappedNode, bool pageChanged) override {}

277 void show(WebNavigationPolicy) override {}	276 void show(WebNavigationPolicy) override {}

278 WebRect windowRect() override { return WebRect(); }	277 WebRect windowRect() override { return WebRect(); }

279 WebRect windowResizerRect() override { return WebRect(); }	278 WebRect windowResizerRect() override { return WebRect(); }

	279 WebWidgetClient* widgetClient() { return this; }
	Avi (use Gerrit) 2016/07/18 15:15:58 Do you see this becoming a permanent call on WebVi Do you see this becoming a permanent call on WebViewClient? lfg 2016/07/18 15:20:25 No. See my comment here: https://codereview.chromi Show quoted text On 2016/07/18 15:15:58, Avi wrote: > Do you see this becoming a permanent call on WebViewClient? No. See my comment here: https://codereview.chromium.org/2121373002/ . I hope we can remove this as soon as possible, but it's important until WebView can instantiate a WebWidget.
280	280

281 protected:	281 protected:

282 ~WebViewClient() { }	282 ~WebViewClient() { }

283 };	283 };

284	284

285 } // namespace blink	285 } // namespace blink

286	286

287 #endif	287 #endif

OLD	NEW