third_party/WebKit/Source/core/page/scrolling/RootScrollerController.h - Issue 2128543002: Make ViewportScrollCallback an interface and add child and root classes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/scrolling/RootScrollerController.h

Issue 2128543002: Make ViewportScrollCallback an interface and add child and root classes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@moveViewportCreationToDocumentAttachment

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/page/scrolling/ChildViewportScrollCallback.cpp ('k') | third_party/WebKit/Source/core/page/scrolling/RootScrollerController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/scrolling/RootScrollerController.h

diff --git a/third_party/WebKit/Source/core/page/scrolling/RootScrollerController.h b/third_party/WebKit/Source/core/page/scrolling/RootScrollerController.h

index b42428a55f420b53fde6b5d51ce6e44532789db4..8519dbf61d7d466e0fdb41e72ce70a8fd52bbbb6 100644

--- a/third_party/WebKit/Source/core/page/scrolling/RootScrollerController.h

+++ b/third_party/WebKit/Source/core/page/scrolling/RootScrollerController.h

@@ -12,8 +12,6 @@ namespace blink {

class Document;

class Element;

-class OverscrollController;

-class TopControls;

class ViewportScrollCallback;

// Manages the root scroller associated with a given document. The root scroller

@@ -49,13 +47,6 @@ public:

return new RootScrollerController(document, applyScrollCallback);

}

- // Creates an apply scroll callback that handles viewport actions like

- // TopControls movement and Overscroll. The TopControls and

- // OverscrollController are given to the ViewportScrollCallback but are not

- // owned or kept alive by it.

- static ViewportScrollCallback* createViewportApplyScroll(

- TopControls*, OverscrollController*);

DECLARE_TRACE();

// Sets the element that will be used as the root scroller. This can be