third_party/WebKit/Source/core/page/scrolling/RootScrollerController.cpp - Issue 2128543002: Make ViewportScrollCallback an interface and add child and root classes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/scrolling/RootScrollerController.cpp

Issue 2128543002: Make ViewportScrollCallback an interface and add child and root classes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@moveViewportCreationToDocumentAttachment

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/page/scrolling/RootScrollerController.h ('k') | third_party/WebKit/Source/core/page/scrolling/RootViewportScrollCallback.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/scrolling/RootScrollerController.cpp

diff --git a/third_party/WebKit/Source/core/page/scrolling/RootScrollerController.cpp b/third_party/WebKit/Source/core/page/scrolling/RootScrollerController.cpp

index 3822b25a1edc66b69aaa002e0c44ec1a3e61c19e..1afccc53a771223f6d28e0aae3d343478dc51463 100644

--- a/third_party/WebKit/Source/core/page/scrolling/RootScrollerController.cpp

+++ b/third_party/WebKit/Source/core/page/scrolling/RootScrollerController.cpp

@@ -73,12 +73,6 @@ bool isValidRootScroller(const Element& element)

} // namespace

-ViewportScrollCallback* RootScrollerController::createViewportApplyScroll(

- TopControls* topControls, OverscrollController* overscrollController)

- return new ViewportScrollCallback(topControls, overscrollController);

RootScrollerController::RootScrollerController(Document& document, ViewportScrollCallback* applyScrollCallback)

: m_document(&document)

, m_viewportApplyScroll(applyScrollCallback)