third_party/WebKit/Source/core/paint/SVGPaintContext.h - Issue 2128463002: Pixel snap SVG's root border box to local transform [spv2]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/SVGPaintContext.h

Issue 2128463002: Pixel snap SVG's root border box to local transform [spv2] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rename to transformToPixelSnappedBorderBox, improve comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp ('k') | third_party/WebKit/Source/core/paint/SVGRootPainter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/SVGPaintContext.h

diff --git a/third_party/WebKit/Source/core/paint/SVGPaintContext.h b/third_party/WebKit/Source/core/paint/SVGPaintContext.h

index f3c84dd5e6b4dcfa6d3a5ceb4edfb17ea8edc88e..8a63a1adc6307ace3f4cb38f2302f0484b0c2b3c 100644

--- a/third_party/WebKit/Source/core/paint/SVGPaintContext.h

+++ b/third_party/WebKit/Source/core/paint/SVGPaintContext.h

@@ -61,9 +61,7 @@ public:

// If a transform exists, we can rely on a layer existing to apply it.

DCHECK(!objectProperties || !objectProperties->transform() || object.hasLayer());

if (objectProperties->svgLocalToBorderBoxTransform()) {

- // FIXME(pdr): Enable the following DCHECK once the pixel snapping logic has

- // been included in svgLocalToBorderBox.

- // DCHECK(objectProperties->svgLocalToBorderBoxTransform()->matrix() == transform.toTransformationMatrix());

+ DCHECK(objectProperties->svgLocalToBorderBoxTransform()->matrix() == transform.toTransformationMatrix());

auto& paintController = context.getPaintController();

PaintChunkProperties properties(paintController.currentPaintChunkProperties());

properties.transform = objectProperties->svgLocalToBorderBoxTransform();