third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp - Issue 2128463002: Pixel snap SVG's root border box to local transform [spv2]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp

Issue 2128463002: Pixel snap SVG's root border box to local transform [spv2] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rename to transformToPixelSnappedBorderBox, improve comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 ('k') | third_party/WebKit/Source/core/paint/SVGPaintContext.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp

index 6fc452dd2a16499606d9e85798a77dac27e5d32f..65fa062fec1928cf21f29f08e7921510a16f5077 100644

--- a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp

@@ -12,6 +12,7 @@

#include "core/layout/svg/LayoutSVGRoot.h"

#include "core/paint/ObjectPaintProperties.h"

#include "core/paint/PaintLayer.h"

+#include "core/paint/SVGRootPainter.h"

#include "platform/transforms/TransformationMatrix.h"

#include "wtf/PtrUtil.h"

#include <memory>

@@ -261,13 +262,12 @@ void PaintPropertyTreeBuilder::updateSvgLocalToBorderBoxTransform(const LayoutOb

if (!object.isSVGRoot())

return;

- AffineTransform transform = AffineTransform::translation(context.paintOffset.x().toFloat(), context.paintOffset.y().toFloat());

- transform *= toLayoutSVGRoot(object).localToBorderBoxTransform();

- if (transform.isIdentity())

+ AffineTransform transformToBorderBox = SVGRootPainter(toLayoutSVGRoot(object)).transformToPixelSnappedBorderBox(context.paintOffset);

+ if (transformToBorderBox.isIdentity())

return;

RefPtr<TransformPaintPropertyNode> svgLocalToBorderBoxTransform = TransformPaintPropertyNode::create(

- transform, FloatPoint3D(0, 0, 0), context.currentTransform);

+ transformToBorderBox, FloatPoint3D(0, 0, 0), context.currentTransform);

context.currentTransform = svgLocalToBorderBoxTransform.get();

context.paintOffset = LayoutPoint();

object.getMutableForPainting().ensureObjectPaintProperties().setSvgLocalToBorderBoxTransform(svgLocalToBorderBoxTransform.release());