Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2128453002: (WIP) gpu, cmaa: handle only staircase case for 2 edge case

Created:
4 years, 5 months ago by dshwang
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu, cmaa: handle only staircase case for 2 edge case Two edge case is a bit complicated. We want to handle only staircase case. The staircase case consists of small staircase and Z shape. Define "small staircase" as at least 2 texels form Z shape. Standard form Variants __ |__ __ __ |__ X| X| | X | X| ¯¯ ¯¯ ¯¯ ¯¯| ¯¯| Define "Z shape" as at least 4 texels form Z shape. __ __ X| ¯¯ ¯¯ Anything else will be skipped. e.g. Parallel |X| Isolated L shape _ _ X| X| |X |X ¯¯ ¯¯ Large L shape _ _ | | _ _ X| X| |X |X | ¯¯¯¯ ¯¯¯¯ | etc.. This CL fixes 2 WebGL conformance tests, which fail due to isolated L shape. https://www.khronos.org/registry/webgl/sdk/tests/conformance/context/context-size-change.html https://www.khronos.org/registry/webgl/sdk/tests/conformance/textures/misc/copy-tex-image-and-sub-image-2d.html Yang Gu checked all WebGL conformance tests are passed with CMAA. BUG=535198 TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders" CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -197 lines) Patch
M gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc View 4 chunks +165 lines, -197 lines 0 comments Download

Messages

Total messages: 2 (2 generated)
dshwang
Description was changed from ========== gpu, cmaa: handle only staircase case for 2 edge case ...
4 years, 5 months ago (2016-07-05 18:45:12 UTC) #1
dshwang
4 years, 5 months ago (2016-07-05 18:48:35 UTC) #2 
Description was changed from

==========
gpu, cmaa: handle only staircase case for 2 edge case

Two edge case is a bit complicated. We want to handle only staircase
case. The staircase case consists of small staircase and Z shape.

Define "small staircase" as at least 2 texels form Z shape.

Standard form     Variants
   __             |__       __ __      |__
   X|              X|      |   X |      X|
    ¯¯              ¯¯ ¯¯        ¯¯|     ¯¯|

Define "Z shape" as at least 4 texels form Z shape.
__ __
   X|
     ¯¯ ¯¯

Anything else will be skipped.
e.g.
Parallel  |X|

Isolated L shape
  _                                   _
  X|          X|         |X          |X
              ¯¯         ¯¯
Large L shape
_ _         |     |         _ _
  X|       X|     |X       |X
   |     ¯¯¯¯     ¯¯¯¯     |

etc..

This CL fixes 2 WebGL conformance tests, which fail due to isolated L shape.
https://www.khronos.org/registry/webgl/sdk/tests/conformance/context/context-...
https://www.khronos.org/registry/webgl/sdk/tests/conformance/textures/misc/co...

Yang Gu checked all WebGL conformance tests are passed with CMAA.

BUG=535198
TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders"
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
gpu, cmaa: handle only staircase case for 2 edge case

Two edge case is a bit complicated. We want to handle only staircase
case. The staircase case consists of small staircase and Z shape.

Define "small staircase" as at least 2 texels form Z shape.

Standard form     Variants
   __             |__       __ __      |__
   X|              X|      |   X |      X|
    ¯¯              ¯¯ ¯¯        ¯¯|     ¯¯|

Define "Z shape" as at least 4 texels form Z shape.
__ __
   X|
     ¯¯ ¯¯

Anything else will be skipped.
e.g.
Parallel  |X|

Isolated L shape
  _                                   _
  X|          X|         |X          |X
              ¯¯         ¯¯
Large L shape
_ _         |     |         _ _
  X|       X|     |X       |X
   |     ¯¯¯¯     ¯¯¯¯     |

etc..

This CL fixes 2 WebGL conformance tests, which fail due to isolated L shape.
https://www.khronos.org/registry/webgl/sdk/tests/conformance/context/context-...
https://www.khronos.org/registry/webgl/sdk/tests/conformance/textures/misc/co...

Yang Gu checked all WebGL conformance tests are passed with CMAA.

BUG=535198
TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders"
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

Powered by Google App Engine
This is Rietveld 408576698