Issue 212843004: Remove static bmp from shadertext3

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 212843004: Remove static bmp from shadertext3 (Closed)

Created:
6 years, 9 months ago by bsalomon

Modified:
6 years, 9 months ago

Reviewers:
mtklein

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Remove static bmp from shadertext3 Committed: http://code.google.com/p/skia/source/detail?r=13959

Patch Set 1 #

Total comments: 2

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -12 lines)			Patch
	M	gm/shadertext3.cpp	View		4 chunks	+13 lines, -12 lines	2 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

mtklein

lgtm https://codereview.chromium.org/212843004/diff/1/gm/shadertext3.cpp File gm/shadertext3.cpp (right): https://codereview.chromium.org/212843004/diff/1/gm/shadertext3.cpp#newcode51 gm/shadertext3.cpp:51: static const int kTextLen = SK_ARRAY_COUNT(kText) - 1; ...

6 years, 9 months ago (2014-03-26 20:47:17 UTC) #2

bsalomon

https://codereview.chromium.org/212843004/diff/1/gm/shadertext3.cpp File gm/shadertext3.cpp (right): https://codereview.chromium.org/212843004/diff/1/gm/shadertext3.cpp#newcode51 gm/shadertext3.cpp:51: static const int kTextLen = SK_ARRAY_COUNT(kText) - 1; On ...

6 years, 9 months ago (2014-03-26 20:49:02 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/212843004/1

6 years, 9 months ago (2014-03-26 20:49:08 UTC) #5

Message was sent while issue was closed.

Change committed as 13959

Expand Messages | Collapse Messages