Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2128333002: Move PlatformSceen to services/ui/display. (Closed)

Created:
4 years, 5 months ago by kylechar
Modified:
4 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move PlatformSceen to services/ui/display. Display management code for mus will live services/ui/display. Start moving existing code. Change namespace from ui::ws:: to ui::display::. BUG=626412 Committed: https://crrev.com/8799b385624ccbed215891b5c57d97148ffbcadb Cr-Commit-Position: refs/heads/master@{#404394}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -319 lines) Patch
A services/ui/display/BUILD.gn View 1 chunk +34 lines, -0 lines 0 comments Download
A + services/ui/display/platform_screen.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + services/ui/display/platform_screen_impl.h View 2 chunks +6 lines, -10 lines 0 comments Download
A + services/ui/display/platform_screen_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A + services/ui/display/platform_screen_impl_ozone.h View 3 chunks +6 lines, -6 lines 0 comments Download
A + services/ui/display/platform_screen_impl_ozone.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M services/ui/service.h View 2 chunks +6 lines, -2 lines 0 comments Download
M services/ui/service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M services/ui/ws/BUILD.gn View 3 chunks +1 line, -14 lines 0 comments Download
D services/ui/ws/platform_screen.h View 1 chunk +0 lines, -43 lines 0 comments Download
D services/ui/ws/platform_screen_impl.h View 1 chunk +0 lines, -39 lines 0 comments Download
D services/ui/ws/platform_screen_impl.cc View 1 chunk +0 lines, -43 lines 0 comments Download
D services/ui/ws/platform_screen_impl_ozone.h View 1 chunk +0 lines, -53 lines 0 comments Download
D services/ui/ws/platform_screen_impl_ozone.cc View 1 chunk +0 lines, -96 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
kylechar
4 years, 5 months ago (2016-07-07 18:26:32 UTC) #2
sky
LGTM
4 years, 5 months ago (2016-07-07 21:23:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2128333002/1
4 years, 5 months ago (2016-07-08 13:45:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 15:41:16 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 15:41:20 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 15:45:20 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8799b385624ccbed215891b5c57d97148ffbcadb
Cr-Commit-Position: refs/heads/master@{#404394}

Powered by Google App Engine
This is Rietveld 408576698