Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1104)

Unified Diff: chrome/browser/ui/views/accelerator_table.cc

Issue 2128243003: Make most browser accelerators not repeat. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/accelerator_table.cc
diff --git a/chrome/browser/ui/views/accelerator_table.cc b/chrome/browser/ui/views/accelerator_table.cc
index d1a069f68382935906782042104dc3d7c7059c10..a170d377c92951e2c64b3f543569eaa673fbf1e6 100644
--- a/chrome/browser/ui/views/accelerator_table.cc
+++ b/chrome/browser/ui/views/accelerator_table.cc
@@ -179,7 +179,7 @@ const AcceleratorMapping kAcceleratorMap[] = {
// via WM_APPCOMMAND.
{ ui::VKEY_BROWSER_SEARCH, ui::EF_NONE, IDC_FOCUS_SEARCH },
{ ui::VKEY_M, ui::EF_SHIFT_DOWN | kPlatformModifier, IDC_SHOW_AVATAR_MENU},
- // On ChromeOS, these keys are assigned to change UI scale.
+ // On Chrome OS, these keys are assigned to change UI scale.
{ ui::VKEY_OEM_PLUS, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN, IDC_ZOOM_PLUS },
{ ui::VKEY_OEM_MINUS, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN,
IDC_ZOOM_MINUS },
@@ -198,6 +198,18 @@ const AcceleratorMapping kAcceleratorMap[] = {
};
const size_t kAcceleratorMapLength = arraysize(kAcceleratorMap);
+const int kRepeatableCommandIds[] = {
+ IDC_FIND_NEXT,
+ IDC_FIND_PREVIOUS,
+ IDC_FOCUS_NEXT_PANE,
+ IDC_FOCUS_PREVIOUS_PANE,
+ IDC_MOVE_TAB_NEXT,
+ IDC_MOVE_TAB_PREVIOUS,
+ IDC_SELECT_NEXT_TAB,
+ IDC_SELECT_PREVIOUS_TAB,
+};
+const size_t kRepeatableCommandIdsLength = arraysize(kRepeatableCommandIds);
+
#if defined(USE_ASH)
// Below we map Chrome command ids to Ash action ids for commands that have
// an shortcut that is handled by Ash (instead of Chrome). Adding entries
@@ -268,4 +280,9 @@ bool GetStandardAcceleratorForCommandId(int command_id,
return false;
}
+std::vector<int> GetRepeatableCommandIds() {
+ return std::vector<int>(kRepeatableCommandIds,
sky 2016/08/31 23:46:24 Can this be a set?
Daniel Erat 2016/09/01 16:48:29 yep, looks like it can!
+ kRepeatableCommandIds + kRepeatableCommandIdsLength);
+}
+
} // namespace chrome

Powered by Google App Engine
This is Rietveld 408576698