Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Unified Diff: chrome/browser/ui/views/accelerator_table_unittest.cc

Issue 2128243003: Make most browser accelerators not repeat. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/accelerator_table_unittest.cc
diff --git a/chrome/browser/ui/views/accelerator_table_unittest.cc b/chrome/browser/ui/views/accelerator_table_unittest.cc
index 31bf6e497ea278c6c2991982421fde1d03697705..3be3bc20892cb98d745c948b8b5ee490a70412d1 100644
--- a/chrome/browser/ui/views/accelerator_table_unittest.cc
+++ b/chrome/browser/ui/views/accelerator_table_unittest.cc
@@ -45,6 +45,15 @@ TEST(AcceleratorTableTest, CheckDuplicatedAccelerators) {
}
}
+TEST(AcceleratorTableTest, CheckDuplicatedRepeatableCommandIds) {
+ std::set<int> commands;
+ const std::vector<int> command_list(GetRepeatableCommandIds());
+ for (int command : command_list) {
+ EXPECT_TRUE(commands.insert(command).second)
+ << "Duplicated command ID " << command;
+ }
+}
+
#if defined(OS_CHROMEOS)
TEST(AcceleratorTableTest, CheckDuplicatedAcceleratorsAsh) {
std::set<AcceleratorMapping, Cmp> accelerators;

Powered by Google App Engine
This is Rietveld 408576698