Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2128173005: Rietveld: don't email on "Dry Run: CQ is trying da patch" (Closed)

Created:
4 years, 5 months ago by tandrii(chromium)
Modified:
4 years, 5 months ago
Reviewers:
Sergiy Byelozyorov
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Rietveld: don't email on "Dry Run: CQ is trying da patch" Before Rietveld sent emails to authors and whoever triggered CQ dry run. With this CL, no email will be sent when Dry Run starts. The email when Dry Run ends will still be sent. BUG=626427

Patch Set 1 #

Patch Set 2 : Fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -17 lines) Patch
M appengine/chromium_rietveld/codereview/utils.py View 1 2 chunks +22 lines, -4 lines 0 comments Download
M appengine/chromium_rietveld/codereview/views.py View 1 1 chunk +16 lines, -13 lines 0 comments Download
M appengine/chromium_rietveld/tests/test_utils.py View 1 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tandrii(chromium)
PTAL
4 years, 5 months ago (2016-07-08 14:43:11 UTC) #3
tandrii(chromium)
another great idea from Sergiyb resulted in https://codereview.chromium.org/2137553002
4 years, 5 months ago (2016-07-08 15:09:52 UTC) #4
Sergiy Byelozyorov
Are you planning to update this CL or should we just close it?
4 years, 5 months ago (2016-07-11 19:33:27 UTC) #5
tandrii(chromium)
4 years, 5 months ago (2016-07-12 12:58:12 UTC) #6
Message was sent while issue was closed.
On 2016/07/11 19:33:27, Sergiy Byelozyorov wrote:
> Are you planning to update this CL or should we just close it?

closed it.

Powered by Google App Engine
This is Rietveld 408576698