Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Unified Diff: chrome/browser/resources/settings/site_settings/site_details_permission.html

Issue 2128173002: Move settings_dropdown_menu styling to settings_shared_css. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Feedback Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/site_settings/site_details_permission.html
diff --git a/chrome/browser/resources/settings/site_settings/site_details_permission.html b/chrome/browser/resources/settings/site_settings/site_details_permission.html
index 42c7b56a7428464a9015c2d9a6fc0f565ae53003..ac6a4b78c7e6ad7c3edfa62fe29d34ed94c9d5c1 100644
--- a/chrome/browser/resources/settings/site_settings/site_details_permission.html
+++ b/chrome/browser/resources/settings/site_settings/site_details_permission.html
@@ -18,16 +18,6 @@
display: block;
}
- paper-dropdown-menu {
- --paper-input-container-input: {
- font-size: inherit;
- };
-
- --paper-font-caption: {
- font-size: inherit;
- }
- }
-
.left-column {
-webkit-margin-start: 15px;
}
@@ -71,14 +61,14 @@
<paper-listbox id="permission" class="dropdown-content"
on-iron-activate="onPermissionMenuIronActivate_"
attr-for-selected="data-permission-value">
- <paper-item id="allow"
+ <div id="allow" class="dropdown-item"
dpapad 2016/07/07 21:03:55 Same here and below, role="option"
stevenjb 2016/07/07 21:39:06 Done.
data-permission-value$="[[PermissionValues.ALLOW]]">
[[i18n_.allowAction]]
- </paper-item>
- <paper-item id="block"
+ </div>
+ <div id="block" class="dropdown-item"
data-permission-value$="[[PermissionValues.BLOCK]]">
[[i18n_.blockAction]]
- </paper-item>
+ </div>
</paper-listbox>
</paper-dropdown-menu>
</div>

Powered by Google App Engine
This is Rietveld 408576698