chrome/browser/resources/settings/site_settings/media_picker.html - Issue 2128173002: Move settings_dropdown_menu styling to settings_shared_css.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/site_settings/media_picker.html

Issue 2128173002: Move settings_dropdown_menu styling to settings_shared_css. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Feedback Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/settings_shared_css.html ('k') | chrome/browser/resources/settings/site_settings/site_details_permission.html » ('j') | chrome/browser/resources/settings/site_settings/site_details_permission.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/site_settings/media_picker.html

diff --git a/chrome/browser/resources/settings/site_settings/media_picker.html b/chrome/browser/resources/settings/site_settings/media_picker.html

index f7dd9dc1620cc84f41ea41c237ee0ccba8e3c149..50a696ee7709bd68fd00280b8d942f3b2f7286ad 100644

--- a/chrome/browser/resources/settings/site_settings/media_picker.html

+++ b/chrome/browser/resources/settings/site_settings/media_picker.html

@@ -10,16 +10,6 @@

:host {

display: block;

}

- paper-dropdown-menu {

- --paper-input-container-input: {

- font-size: inherit;

- };

- --paper-font-caption: {

- font-size: inherit;

- }

</style>

<paper-dropdown-menu>

@@ -27,9 +17,9 @@

attr-for-selected="media-picker-value"

on-iron-activate="onMediaPickerActivate_">

- <paper-item media-picker-value$="[[item.id]]">

+ <div class="dropdown-item" media-picker-value$="[[item.id]]">

dpapad 2016/07/07 21:03:55 Let's add role="option" for accessibility.

stevenjb 2016/07/07 21:39:06 Done.

[[item.name]]

- </paper-item>

+ </div>

</template>

</paper-listbox>

</paper-dropdown-menu>