Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(805)

Unified Diff: media/base/data_source.h

Issue 212803004: Separate DemuxerHost from DataSourceHost. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update other implementations of DataSourceHost and DemuxerHost. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/data_source.h
diff --git a/media/base/data_source.h b/media/base/data_source.h
index 9176c8e845c531720fec86ba6b0b165194fc0ec5..98b9f1f050f95084aad93dcd520b3b30ae0ed8a8 100644
--- a/media/base/data_source.h
+++ b/media/base/data_source.h
@@ -11,6 +11,7 @@
namespace media {
+// TODO(sandersd): Rename to BufferedDataSourceHost.
scherkus (not reviewing) 2014/03/28 20:54:09 nit: ... and move to content/renderer/media/
sandersd (OOO until July 31) 2014/03/28 21:14:28 Done.
class MEDIA_EXPORT DataSourceHost {
public:
// Set the total size of the media file.
@@ -21,10 +22,6 @@ class MEDIA_EXPORT DataSourceHost {
// pull-based. http://crbug.com/131444
virtual void AddBufferedByteRange(int64 start, int64 end) = 0;
- // Notify the host that time range [start,end] has been buffered.
- virtual void AddBufferedTimeRange(base::TimeDelta start,
- base::TimeDelta end) = 0;
-
protected:
virtual ~DataSourceHost();
};
@@ -38,8 +35,6 @@ class MEDIA_EXPORT DataSource {
DataSource();
virtual ~DataSource();
- virtual void set_host(DataSourceHost* host);
-
// Reads |size| bytes from |position| into |data|. And when the read is done
// or failed, |read_cb| is called with the number of bytes read or
// kReadError in case of error.
@@ -62,12 +57,7 @@ class MEDIA_EXPORT DataSource {
// Values of |bitrate| <= 0 are invalid and should be ignored.
virtual void SetBitrate(int bitrate) = 0;
- protected:
- DataSourceHost* host();
-
private:
- DataSourceHost* host_;
-
DISALLOW_COPY_AND_ASSIGN(DataSource);
};

Powered by Google App Engine
This is Rietveld 408576698