content/renderer/media/webmediaplayer_impl.cc - Issue 212803004: Separate DemuxerHost from DataSourceHost.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webmediaplayer_impl.cc

Issue 212803004: Separate DemuxerHost from DataSourceHost. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update other implementations of DataSourceHost and DemuxerHost. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/media/webmediaplayer_impl.cc

diff --git a/content/renderer/media/webmediaplayer_impl.cc b/content/renderer/media/webmediaplayer_impl.cc

index 952f644fe83c38f9eb232b7820708f43aa2be5ae..5bbe5d7873c3370d15d0ccda40c6b778a12dbe80 100644

--- a/content/renderer/media/webmediaplayer_impl.cc

+++ b/content/renderer/media/webmediaplayer_impl.cc

@@ -306,10 +306,13 @@ void WebMediaPlayerImpl::DoLoad(LoadType load_type,

}

// Otherwise it's a regular request which requires resolving the URL first.

+ // TODO(sandersd): Make WMPI a DataSourceHost and pass &this instead of

scherkus (not reviewing) 2014/03/28 20:54:09 nit: &this would be a WMPI** -- you probably mean

sandersd (OOO until July 31) 2014/03/28 21:14:28 Done.

+ // &pipeline_.

data_source_.reset(new BufferedDataSource(

main_loop_,

frame_,

media_log_.get(),

+ &pipeline_,

base::Bind(&WebMediaPlayerImpl::NotifyDownloading, AsWeakPtr())));

data_source_->Initialize(

url, static_cast<BufferedResourceLoader::CORSMode>(cors_mode),