DescriptionRevert of Set the default ASan options for executables built with ASan on Linux. (https://codereview.chromium.org/201153007/)
Reason for revert:
Broke ChromiumOS ASan build.
http://build.chromium.org/p/chromium.memory/builders/Chromium%20OS%20%28x86%29%20ASan/builds/8778/steps/BuildPackages/logs/stdio
Original issue's description:
> Set the default ASan options for executables built with ASan on Linux.
>
> This is a copy of https://codereview.chromium.org/25687005/ updated for the current trunk
> with the link_dependency attribute speculatively added to base/base.gyp:sanitizer_options
> to avoid potential dependency cycles.
>
> This CL introduces a module, base/debug/sanitizer_options.cc, which will override
> the defaults for various dynamic tools (only ASan at this moment). For every executable
> built with a dynamic tool this module will be linked into that executable, providing
> weak functions to be called by the tool.
>
> The existing declaration of __asan_default_options() in chrome/app/chrome_exe_main_gtk.cc
> has been moved into sanitizer_options.cc (now every binary built with GOOGLE_CHROME_BUILD=1
> will have the same options as google-chrome-asan.
> The existing declaration of __asan_default_options() in chrome/nacl/nacl_helper_linux.cc
> has been kept as is, but we had to remove -Wl,-u_sanitizer_options_link_helper to avoid picking sanitizer_options.cc.
>
> GYP changes for OSX and iOS will be committed separately.
>
> BUG=302040
> TBR=thakis@chromium.org
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259561
TBR=thakis@chromium.org,glider@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=302040
Patch Set 1 #
Created: 6 years, 9 months ago
(Patch set is too large to download)
Messages
Total messages: 6 (0 generated)
|