Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1272)

Issue 212793010: Revert of Set the default ASan options for executables built with ASan on Linux. (Closed)

Created:
6 years, 9 months ago by tkent
Modified:
6 years, 9 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Revert of Set the default ASan options for executables built with ASan on Linux. (https://codereview.chromium.org/201153007/) Reason for revert: Broke ChromiumOS ASan build. http://build.chromium.org/p/chromium.memory/builders/Chromium%20OS%20%28x86%29%20ASan/builds/8778/steps/BuildPackages/logs/stdio Original issue's description: > Set the default ASan options for executables built with ASan on Linux. > > This is a copy of https://codereview.chromium.org/25687005/ updated for the current trunk > with the link_dependency attribute speculatively added to base/base.gyp:sanitizer_options > to avoid potential dependency cycles. > > This CL introduces a module, base/debug/sanitizer_options.cc, which will override > the defaults for various dynamic tools (only ASan at this moment). For every executable > built with a dynamic tool this module will be linked into that executable, providing > weak functions to be called by the tool. > > The existing declaration of __asan_default_options() in chrome/app/chrome_exe_main_gtk.cc > has been moved into sanitizer_options.cc (now every binary built with GOOGLE_CHROME_BUILD=1 > will have the same options as google-chrome-asan. > The existing declaration of __asan_default_options() in chrome/nacl/nacl_helper_linux.cc > has been kept as is, but we had to remove -Wl,-u_sanitizer_options_link_helper to avoid picking sanitizer_options.cc. > > GYP changes for OSX and iOS will be committed separately. > > BUG=302040 > TBR=thakis@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259561 TBR=thakis@chromium.org,glider@chromium.org NOTREECHECKS=true NOTRY=true BUG=302040

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -88 lines) Patch
M base/base.gyp View 1 chunk +0 lines, -25 lines 0 comments Download
D base/debug/sanitizer_options.cc View 1 chunk +0 lines, -49 lines 0 comments Download
M build/common.gypi View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/app/chrome_exe_main_gtk.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M components/nacl.gyp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tkent
Created Revert of Set the default ASan options for executables built with ASan on Linux.
6 years, 9 months ago (2014-03-27 11:40:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/212793010/1
6 years, 9 months ago (2014-03-27 11:40:37 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 11:41:00 UTC) #3
commit-bot: I haz the power
Failed to apply patch for base/base.gyp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 9 months ago (2014-03-27 11:41:01 UTC) #4
tkent
omg, closing.
6 years, 9 months ago (2014-03-27 11:43:20 UTC) #5
Alexander Potapenko
6 years, 9 months ago (2014-03-27 16:29:14 UTC) #6
Message was sent while issue was closed.
FTR the remaining issue with CrOS ASan bot is unrelated to this CL.

Powered by Google App Engine
This is Rietveld 408576698